This repository has been archived by the owner. It is now read-only.
Remove sendifunverified logic #4424
Merged
Conversation
|
@vbudhram what other changes do we need for this? |
|
@vladikoff Nope, just wanted to wait for mozilla/fxa-js-client#219. This is ready now, r? |
|
@vbudhram why was this waiting for fxa-js-client? do we need to include a new version of the js client in the PR? |
| @@ -344,19 +343,6 @@ define(function (require, exports, module) { | |||
| signInAccount (account, password, relier, options) { | |||
| return account.signIn(password, relier, options) | |||
| .then(() => { | |||
| const isSignUp = | |||
vladikoff
Nov 24, 2016
Contributor
👍
|
@vladikoff This change is backwards compatible with current js client, but we should still update content-server once we tag next version of client. |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The auth-server now defaults to sending emails
sendEmailIfUnverified=true, content server does not need to send over this.