Skip to content
This repository has been archived by the owner. It is now read-only.

fix(tests): add SRI testing to functional tests #4432

Merged
merged 1 commit into from Nov 22, 2016
Merged

fix(tests): add SRI testing to functional tests #4432

merged 1 commit into from Nov 22, 2016

Conversation

@vladikoff
Copy link
Contributor

@vladikoff vladikoff commented Nov 21, 2016

@shane-tomlinson
Copy link
Member

@shane-tomlinson shane-tomlinson commented Nov 21, 2016

awesome!

@vbudhram
Copy link
Contributor

@vbudhram vbudhram commented Nov 22, 2016

@vladikoff Test works great when running local content-server in production mode. I reran the CI tests a couple of times and got the same error

× firefox on any platform - Firefox Desktop Sync v1 reset_password - reset password, verify different browser - from original tab's P.O.V. (6.648s) AssertionError: expected false to be true

I think these are unrelated, r+ unless you think otherwise.

@shane-tomlinson
Copy link
Member

@shane-tomlinson shane-tomlinson commented Nov 22, 2016

× firefox on any platform - Firefox Desktop Sync v1 reset_password - reset password, verify different browser - from original tab's P.O.V. (6.648s) AssertionError: expected false to be true

This is fixed by #4428, just need to rebase.

@vladikoff vladikoff merged commit d99d598 into master Nov 22, 2016
3 of 4 checks passed
3 of 4 checks passed
ci/circleci Your tests failed on CircleCI
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 98.604%
Details
@vladikoff vladikoff deleted the i4364 branch Nov 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants