This repository has been archived by the owner. It is now read-only.
fix(client): Use the server returned email when signing in. #4472
Conversation
Signin unblock is broken if the user types their email using different casing to when they signed up. The auth server returns an error that says "Feature not enabled". This fixes that by updating the model with the email that is returned by the server if it returns an INCORRECT_EMAIL_CASE error. Unfortunately, the sync v3 functional test fails, trying to figure out why. fixes #3893 fixes #4467
|
This is #4469 opened against train-75 |
This was referenced Nov 29, 2016
vladikoff
deleted the
shane-tomlinson/issue-4467-signin-retry-incorrect-case-train-75
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Signin unblock is broken if the user types their email using different
casing to when they signed up. The auth server returns an error that
says "Feature not enabled". This fixes that by updating the model
with the email that is returned by the server if it returns an
INCORRECT_EMAIL_CASE error.
fixes #3893
fixes #4467
@vladikoff - r?