This repository has been archived by the owner. It is now read-only.
fix(client): Canonicalize emails when going to /settings #4473
Conversation
|
Has conflicts... |
Any time account.sessionStatus is called, update the account's email address with the address returned by the server. This forces the server's canonicalized email address to be used instead of any uncanonicalized addresses from before this PR. This is used by base.js for views that require a valid session or verification, such as settings. fixes #4463
shane-tomlinson
force-pushed the
shane-tomlinson/issue-4463-canonical-email-signed-in-users
branch
from
591f769
to
6ac014b
|
@vladikoff - updated. |
vladikoff
deleted the
shane-tomlinson/issue-4463-canonical-email-signed-in-users
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Any time account.sessionStatus is called, update the account's email
address with the address returned by the server. This forces the
server's canonicalized email address to be used instead of any
uncanonicalized addresses from before this PR.
This is used by base.js for views that require a valid session or
verification, such as settings.
fixes #4463
This builds on #4472 and should be reviewed afterwards.
A case not handled by this PR is a user that opens
/signinwith a cached email. Handling the case when the sessionToken was valid was easy, handling the case where the sessionToken was invalid was a big ball of mud, so I deferred it. Will open an issue about it.@vladikoff - r?