This repository has been archived by the owner. It is now read-only.
refactor(client): Clean up complete_sign_up a bit. #4518
Merged
Conversation
| // sign up verification from completing, nor | ||
| // should an error be displayed to the user. | ||
| // Log the error and nothing else. | ||
| this.logError(err); |
vladikoff
Dec 16, 2016
Contributor
👍
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This is an extraction and refinement from #4370. To simplify
adding the new functionality required for #4370, especially
with the tests, I broke up the
beforeRenderfunction so thatindividual components could be tested w/o combinatorial explosion.
This is the result.
@vladikoff - r?