This repository has been archived by the owner. It is now read-only.
feat(connect-another-device): Add a close button to "why connect another device" #4626
Conversation
…her device" fixes #4604
|
@shane-tomlinson I couldn't get this view loaded to access the link when confirming account in FF or Chrome. I get the old view?
Am I missing something in the testing steps? |
|
@shane-tomlinson we might want to add the "Got it" to the Device Disconnect as well (for consistency?) |
|
@vbudhram try forcing the experiment into treatment mode: https://github.com/mozilla/fxa-content-server/blob/master/tests/functional/connect_another_device.js#L103 |
|
@vladikoff yup that did it! |
|
@shane-tomlinson |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
fixes #4604
@ryanfeeley - it looks like this:
@ryanfeeley, @vbudhram - r?