This repository has been archived by the owner. It is now read-only.
fix(account): throw an error when generating assertions with invalid … #4666
Conversation
…session token Fixes #4586
|
This PR sidesteps the filed problem by throwing an error of the format we expect, but it doesn't solve the underlying problem of attempting to generate assertions for accounts w/o valid sessionTokens. I'm OK with merging this, and filing a follow on issue to fix the underlying problem. |
|
@vladikoff - is there anything else you want to do with this PR? If not, can you merge it? We'll need to open a follow up issue to fix the underlying problem instead of just the reporting. The underlying problem is we shouldn't request an assertion if we don't have a sessionToken. |
|
with the latest code, if the token is corrupted then we get the same Invalid Token on force_auth: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
…session token
Fixes #4586
@shane-tomlinson r?