fix(iOS): Send the login message within the visibilitychange

[shane-tomlinson]

For verified accounts, the login message is sent immediately.

For unverified accounts, the login message is sent after the
first of 1) a 5 second timeout, or 2) a blur DOM event.

The blur DOM event is to handle the case where a user receives
their verification email and opens the email client before the timeout
has occurred.

For Fx for iOS >= 6.1, always send the login message immediately.

fixes #4377

[shane-tomlinson]

@vbudhram - mind doing a review of this, even before @st3fan has reported back his tests? I'd like to have the ducks lined up if he says "yeah, works as expected."

[shane-tomlinson]

This code is running on https://stomlinson.dev.lcip.org. I used the config from https://gist.github.com/shane-tomlinson/ac0e30442ebd9f32b13b449239319f60 to test on device. Unfortunately, my device doesn't have @st3fan's patch, so I haven't tested in full.

[shane-tomlinson]

fixes #4377

[vbudhram]

@shane-tomlinson On it 👍, I can also test with the ios patch and make sure all is well.

[vbudhram]

Tested this with the following use cases

FxiOS 6.0

• Sign-in with account verified
  • Sends login message and redirects to settings page
• Sign-in with unverified account, minimize app, click verify email, reopens app
  • Waits 10 seconds, sends login, redirects to settings

FxiOS 6.1 (iOS Patch version)

• Sign-in with account verified
  • Sends login message and redirects to settings page
• Sign-in with unverified account, minimize app, click verify email, reopens app
  • Waits indefinitely at confirm sign-in, clicking back button shows verified user

@shane-tomlinson This LGTM, r+. Something to note with the patched iOS version, after returning to the app from verifying email, the screen will still be on the confirm sign-in page even though they just verified, which could lead to come confusion.

[shane-tomlinson]

redirects to settings

Agh! That's not supposed to happen! It's supposed to redirect to /signup_complete I thought!

[vbudhram]

@shane-tomlinson Updates look r+! This performs exactly as we talked about.

FxiOS 6.1 >=

• Polls until account is verified and then transitions to /signup_complete. User has to hit the top navigation settings button to get back to FxiOS settings screen. The user will show as connected in this page.

Merge at will!