This repository has been archived by the owner. It is now read-only.
fix(experiments): test against the latest tagged branch of experiments #4766
Conversation
|
Ah yes... Or update the tests. |
|
This is a strange one. Since we are still using the experiment infrastructure, the functional tests don't need to be updated. The functional tests by default force users through the "control" group, which is what the existing tests test for. It's just that in real life, nobody will be in the control group. |
Oh great! ok then we don't have to worry about that |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
this change will probably break the tests mozilla/fxa-content-experiments@2bccc5c so we need to fallback
cc @shane-tomlinson