This repository has been archived by the owner. It is now read-only.
fix(sms): Allow parens in the phone number #4773
Merged
Conversation
What is the problem? Parenthesis are not allowed in a phone number. Lots of people surround a US area code with (). How does this fix it? Allow any combination of ( and ). fixes #4764
shane-tomlinson
added
waffle:active
shipit
waffle:review
and removed
waffle:active
labels
|
LGTM! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
What is the problem?
Parenthesis are not allowed in a phone number. Lots of people surround
a US area code with ().
How does this fix it?
Allow any combination of ( and ).
fixes #4764
@mozilla/fxa-devs - r?