feat(sms): Allow the user to resend and go "back" from /sms/sent #4777
Conversation
shane-tomlinson
changed the title
shane-tomlinson
force-pushed the
send-sms-back-from-sms-sent
branch
from
d343db6
to
65faccf
shane-tomlinson
changed the title
shane-tomlinson
force-pushed the
send-sms-back-from-sms-sent
branch
2 times, most recently
from
367e1c5
to
4083d9c
shane-tomlinson
changed the title
|
I can call this ready for review! @mozilla/fxa-devs - r? |
| <section> | ||
| <div class="success visible"> | ||
| {{#t}}App link sent to %(phoneNumber)s.{{/t}} <a id="back" href="#">{{#t}}Mistyped number?{{/t}}</a> |
vladikoff
Mar 7, 2017
Contributor
This should be good for l10n and rtl I hope!
This should be good for l10n and rtl I hope!
shane-tomlinson
Mar 9, 2017
Author
Member
I'll merge the two strings.
I'll merge the two strings.
Combine `App link sent to %(phoneNumber)s` and `Mistyped email?` for better l10n.
shane-tomlinson
force-pushed the
send-sms-back-from-sms-sent
branch
from
4083d9c
to
4f0c858
|
@vladikoff - updated, mind an r? |
|
@shane-tomlinson LGTM
|
| .then(testElementExists(SELECTOR_SMS_SENT_HEADER)) | ||
|
|
||
| // Give a slight delay or else nexmo throttles the request | ||
| .sleep(10000) |
vbudhram
Mar 9, 2017
Contributor
10 seconds seem really long for a delay?
10 seconds seem really long for a delay?
shane-tomlinson
Mar 9, 2017
Author
Member
Yeah, that's Nexmo though. I was thinking for the functional tests, maybe we could open the content server page with a query parameter that causes the /sms page to not actually send the request, but instead just go to the next screen to make sure the UI acts as we expect. Maybe we'd send 1 or 2 requests, 1 to check whether backend phone number validation works, 1 to check whether SMS send is successful.
Yeah, that's Nexmo though. I was thinking for the functional tests, maybe we could open the content server page with a query parameter that causes the /sms page to not actually send the request, but instead just go to the next screen to make sure the UI acts as we expect. Maybe we'd send 1 or 2 requests, 1 to check whether backend phone number validation works, 1 to check whether SMS send is successful.
vbudhram
Mar 9, 2017
Contributor
That sounds good. Doesn't have to go in this PR, just my spider sense going off for when I saw 10seconds.
That sounds good. Doesn't have to go in this PR, just my spider sense going off for when I saw 10seconds.
| } | ||
| const t = msg => msg; | ||
|
|
||
| const UNTRANSLATED_RESENT_MESSAGE = t('Download link resent to %(phoneNumber)s'); |
shane-tomlinson
Mar 9, 2017
Author
Member
@ryanfeeley asked me to change the other text from Download link to App link, we should do the same here.
@ryanfeeley asked me to change the other text from Download link to App link, we should do the same here.
No description provided.