Skip to content
This repository has been archived by the owner. It is now read-only.

feat(CAD): Remove the CAD experiment. #4781

Merged
merged 1 commit into from Mar 23, 2017
Merged

feat(CAD): Remove the CAD experiment. #4781

merged 1 commit into from Mar 23, 2017

Conversation

@shane-tomlinson
Copy link
Member

@shane-tomlinson shane-tomlinson commented Mar 6, 2017

All of the Sync tests where the verification tab searched
for "#fxa-signup-complete-header" had to be updated to
search for "#fxa-connect-another-device-header"

Updated a couple of suites to use helper methods.

@shane-tomlinson shane-tomlinson changed the title FOR DISCUSSION - feat(CAD): Remove the CAD experiment. feat(CAD): Remove the CAD experiment. Mar 7, 2017
@shane-tomlinson shane-tomlinson changed the title feat(CAD): Remove the CAD experiment. FOR DISCUSSION - feat(CAD): Remove the CAD experiment. Mar 7, 2017
@shane-tomlinson shane-tomlinson changed the title FOR DISCUSSION - feat(CAD): Remove the CAD experiment. feat(CAD): Remove the CAD experiment. Mar 7, 2017
@shane-tomlinson shane-tomlinson removed their assignment Mar 7, 2017
@shane-tomlinson
Copy link
Member Author

@shane-tomlinson shane-tomlinson commented Mar 7, 2017

Copy link
Contributor

@vbudhram vbudhram left a comment

@shane-tomlinson I think this comment could be cleaned up since we don't use this experiment. Otherwise, LGTM 👍

@shane-tomlinson shane-tomlinson force-pushed the cad-everywhere branch 2 times, most recently from ccd6b3f to 8d9b610 Mar 21, 2017
All of the Sync tests where the verification tab searched
for "#fxa-signup-complete-header" had to be updated to
search for "#fxa-connect-another-device-header"

Updated a couple of suites to use helper methods.
@shane-tomlinson shane-tomlinson force-pushed the cad-everywhere branch from 8d9b610 to bd83fdd Mar 23, 2017
@shane-tomlinson shane-tomlinson merged commit 912a948 into master Mar 23, 2017
3 checks passed
3 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 98.247%
Details
@shane-tomlinson shane-tomlinson deleted the cad-everywhere branch Mar 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants