This repository has been archived by the owner. It is now read-only.
fix(config): allow env vars for experiment config #4785
Merged
Conversation
server/lib/configuration.js
Outdated
| }, | ||
| watch: { | ||
| default: false, | ||
| doc: 'poll the experiments git repo for changes' | ||
| doc: 'poll the experiments git repo for changes', | ||
| env: 'EXPERIMENTS_POLL' |
philbooth
Mar 7, 2017
Contributor
Shouldn't we also specify a format for this one to ensure it coerces to Boolean correctly?
Also, the current doc and env don't make clear that we're looking for an on/off value here, only the default does. Should we update them to make the booleanness explicit, EXPERIMENTS_ENABLE_POLLING?
(the current name/description could equally apply to, say, milliseconds polling interval)
Shouldn't we also specify a format for this one to ensure it coerces to Boolean correctly?
Also, the current doc and env don't make clear that we're looking for an on/off value here, only the default does. Should we update them to make the booleanness explicit, EXPERIMENTS_ENABLE_POLLING?
(the current name/description could equally apply to, say, milliseconds polling interval)
|
r+, I also a left a little inline comment about including a |
Yeah, exactly the feedback I was looking for, thanks! Will update |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #4780
@mozilla/fxa-devs r?