Skip to content
This repository has been archived by the owner. It is now read-only.

add locale directories #538

Merged
merged 1 commit into from Feb 17, 2014
Merged

add locale directories #538

merged 1 commit into from Feb 17, 2014

Conversation

@zaach
Copy link
Contributor

@zaach zaach commented Feb 13, 2014

This adds directories for all of the locales in mozilla-central/browser/locales/shipped-locales.

We may need more if Fennec or Firefox support additional locales.

  • Check for additional Fennec locales
  • Check for additional FxOS locales
@zaach zaach added the WIP label Feb 13, 2014
@zaach
Copy link
Contributor Author

@zaach zaach commented Feb 13, 2014

The diff is ridiculously big, so instead of an inline comment I'll just link this issue here. I had to work around this by using a [] accessor for static.

msgstr ""

#: app/scripts/templates/cannot_create_account.mustache:3
msgid "You must meet certain age requirements to create a Firefox Account."

This comment has been minimized.

@pdehaan

pdehaan Feb 14, 2014
Contributor

Did we want an   in the string, or did we decide that was more trouble than it's worth?
Actually search/replace is saying there are a bunch of   chars in this, so it's more of a global question I guess.

  1. #333 (comment)
  2. #398 (comment)
  3. #387 (comment)
@pdehaan pdehaan added the i18n label Feb 14, 2014
@pdehaan pdehaan mentioned this pull request Feb 14, 2014
@shane-tomlinson
Copy link
Member

@shane-tomlinson shane-tomlinson commented Feb 14, 2014

From an email on Feb 7:

These teams are:

es-ES, es-AR, and es-CL are more reliable. es-MX, while they've been
turning it around, they're still in flux

Check to ensure these locales are added.

@shane-tomlinson
Copy link
Member

@shane-tomlinson shane-tomlinson commented Feb 14, 2014

@zaach - 46,000 lines is 33,000 lines larger than our old travis logs! Nicely done!

@shane-tomlinson
Copy link
Member

@shane-tomlinson shane-tomlinson commented Feb 14, 2014

@zaach - All of the es-* locales are there, plain old es needs to be added for FxOS.

@pdehaan
Copy link
Contributor

@pdehaan pdehaan commented Feb 14, 2014

On the topic of   in the templates:

$ grep -inr " " . | grep -v "\(node_modules\|dist\|bower_components\)\/"

  1. ./app/scripts/templates/cannot_create_account.mustache:8: <strong>{{#t}}You must meet certain age requirements to create a Firefox&nbsp;Account.{{/t}}</strong>
  2. ./app/scripts/templates/confirm.mustache:12: <p class="verification-email-message">{{#t}}A verification link has been sent&nbsp;to: %(email)s{{/t}}</p>
  3. ./app/scripts/templates/reset_password.mustache:11: <p>{{#t}}Enter your email to reset&nbsp;the account password.{{/t}}</p>
  4. ./locale/templates/LC_MESSAGES/content-server.pot:259:msgid "You must meet certain age requirements to create a Firefox&nbsp;Account."
  5. ./locale/templates/LC_MESSAGES/content-server.pot:363:msgid "A verification link has been sent&nbsp;to: %(email)s"
  6. ./locale/templates/LC_MESSAGES/content-server.pot:413:msgid "Enter your email to reset&nbsp;the account password."
@zaach
Copy link
Contributor Author

@zaach zaach commented Feb 14, 2014

@pdehaan I don't suppose there's anything wrong with those in there. Thoughts @shane-tomlinson ?

@zaach
Copy link
Contributor Author

@zaach zaach commented Feb 14, 2014

I've added additional locales for FxOS, found in https://github.com/mozilla-b2g/gaia/blob/master/locales/languages_all.json.

@zaach
Copy link
Contributor Author

@zaach zaach commented Feb 14, 2014

Alright, I've gone through mozilla-central/mobile/android/locales/all-locales and there weren't any locales we didn't already have. I'm going to consider this list complete. We can add more later if needed.

@zaach zaach removed the WIP label Feb 14, 2014
shane-tomlinson pushed a commit that referenced this pull request Feb 17, 2014
add locale directories

This is a beast @zaach! r+.
@shane-tomlinson shane-tomlinson merged commit a913c86 into master Feb 17, 2014
1 check passed
1 check passed
@rik
default The Travis CI build passed
Details
@shane-tomlinson shane-tomlinson deleted the locale_directories branch Feb 17, 2014
@shane-tomlinson
Copy link
Member

@shane-tomlinson shane-tomlinson commented Feb 17, 2014

@zaach - I merged so that we could avoid bitrot on this portion. One final concern is merging new strings into the already existing po files, is that set up already?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants