Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

add timestamps to log lines; fixes GH-662 #667

Merged
merged 2 commits into from Mar 5, 2014

Conversation

Projects
None yet
3 participants
Member

jrgm commented Mar 5, 2014

(note: there are a couple of startup lines that directly use console.log directly still. I could hook those too, but I don't think it's worth it.)

@shane-tomlinson shane-tomlinson and 1 other commented on an outdated diff Mar 5, 2014

server/bin/fxa-content-server.js
@@ -109,7 +119,7 @@ function listen(theApp) {
app.listen(port, '0.0.0.0');
}
if (isMain) {
- console.log('Firefox Account Content server listening on port', port);
+ logger.error('Firefox Account Content server listening on port', port);
@shane-tomlinson

shane-tomlinson Mar 5, 2014

Member

Do you want this to be piped to stderr?

@jrgm

jrgm Mar 5, 2014

Member

Actually, that's a mistake. Thanks for catching that!

Member

shane-tomlinson commented Mar 5, 2014

@jrgm - I totally dig this. I only have the one question about the use of logger.error to show which port is being listened to.

Member

shane-tomlinson commented Mar 5, 2014

@jrgm - can you also squash these commits and use the log format outlined here so that our changelog extraction tool can do the heavy changelog lifting for us?

Member

jrgm commented Mar 5, 2014

Okay, s/logger.error/logger.info/ in that one place and change the name to match convention.

Contributor

zaach commented Mar 5, 2014

Thanks @jrgm. 👍

@zaach zaach added a commit that referenced this pull request Mar 5, 2014

@zaach zaach Merge pull request #667 from jrgm/timestamps_or_it_didnt_happen
add timestamps to log lines; fixes GH-662
dce41c3

@zaach zaach merged commit dce41c3 into mozilla:master Mar 5, 2014

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment