use npm shrinkwrap #685

merged 1 commit into from Mar 7, 2014


None yet

2 participants

jrgm commented Mar 6, 2014

address #669

The builds on were failing during npm install, and to "fix" this, I hacked the post-update.js script to remote the lockdown preinstall step. Maybe the dependency graph for the content server is tripping up lockdown (it's not small; github's not displaying the npm-shrinkwrap.json file here, due ot size). Anyways, to get things moving, and so I can remove my hack from the dev box, this switches over to using shrinkwrap.

zaach commented Mar 7, 2014

Let's do it. 👍

@zaach zaach merged commit 49fc539 into mozilla:master Mar 7, 2014

1 check passed

default The Travis CI build passed
jrgm commented Mar 7, 2014

In the end, switching from lockdown to shrinkwrap was moot since it was still failing, maybe because it just needs a bigger box to build reliably.

@jrgm jrgm deleted the jrgm:use-shrinkwrap branch Mar 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment