Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(signup): improve styling of password advice #7042

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@lmorchard
Copy link
Member

lmorchard commented Mar 12, 2019

Fixes #6448

@lmorchard

This comment has been minimized.

Copy link
Member Author

lmorchard commented Mar 12, 2019

This PR doesn't include the second bubble for the repeat password field. But, if that's a must for this issue, I can close this and go back to the drawing board for a bit.

@shane-tomlinson

This comment has been minimized.

Copy link
Member

shane-tomlinson commented Mar 13, 2019

Aesthetically, this looks great!

But, if that's a must for this issue, I can close this and go back to the drawing board for a bit.

Both @davismtl and @ryanfeeley want the 2nd bubble there before removing the text from the first bubble so that the user is informed why the password is important.

@lmorchard lmorchard changed the title style(signup): improve styling of password advice WIP style(signup): improve styling of password advice Mar 13, 2019

@lmorchard

This comment has been minimized.

Copy link
Member Author

lmorchard commented Mar 13, 2019

Alrighty, let's call this WIP then and I'll get to work on the 2nd bubble today

@lmorchard lmorchard force-pushed the lmorchard:6448-password-advice-style branch from 39c2cd9 to 68c7f99 Mar 15, 2019

@lmorchard

This comment has been minimized.

Copy link
Member Author

lmorchard commented Mar 15, 2019

I've stumbled my way toward having both bubbles, but a) not entirely sure the behavior is correct and b) I need to explore adding tests

@lmorchard lmorchard force-pushed the lmorchard:6448-password-advice-style branch from 68c7f99 to 8d3f5df Mar 19, 2019

style(signup): improve styling of password advice
- Tweaked styling and text of first password field bubble

- Add second bubble for the repeat password field

Fixes #6448

@lmorchard lmorchard force-pushed the lmorchard:6448-password-advice-style branch from 8d3f5df to 9263051 Mar 19, 2019

@lmorchard lmorchard changed the title WIP style(signup): improve styling of password advice style(signup): improve styling of password advice Mar 19, 2019

@lmorchard

This comment has been minimized.

Copy link
Member Author

lmorchard commented Mar 19, 2019

Okay, going to call this no longer in-progress: Got the second bubble added, along with tests. Could use some input on whether the UX is appropriate, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.