Skip to content
This repository has been archived by the owner. It is now read-only.

config option reputationService.host must be able to accept a FQDN value #166

Closed
jrgm opened this issue Feb 4, 2017 · 4 comments
Closed

config option reputationService.host must be able to accept a FQDN value #166

jrgm opened this issue Feb 4, 2017 · 4 comments

Comments

@jrgm
Copy link
Contributor

@jrgm jrgm commented Feb 4, 2017

  1. In stage/production, the tigerblood endpoint is set up to use an ELB. ELB's advertise multiple IP's and those IP's can change at anytime.

  2. Current master of ip-reputation-js-client, not yet published to npm, hardcodes the scheme to https, which cannot be used with IP addresses.

@jrgm
Copy link
Contributor Author

@jrgm jrgm commented Feb 6, 2017

See also mozilla-services/ip-reputation-js-client#3, where the client should be strictSSL and not follow any redirects. (Not directly related to this bug, but both this repo and that repo need to align).

@vbudhram
Copy link
Contributor

@vbudhram vbudhram commented Feb 8, 2017

Spoke with @g-k and he said that he was working on some patches for this, possibly sending the service url instead.

Connects with mozilla-services/ip-reputation-js-client#3 and mozilla-services/ip-reputation-js-client#4

@g-k
Copy link
Contributor

@g-k g-k commented Feb 9, 2017

ugh, yeah.

The package is published: https://www.npmjs.com/package/ip-reputation-js-client.

If mozilla-services/ip-reputation-js-client#4 addresses mozilla-services/ip-reputation-js-client#3, then I need to:

@vladikoff
Copy link
Contributor

@vladikoff vladikoff commented Feb 21, 2017

This was corrected...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants