feat(basket): Use fxa-basket-proxy for all our basket-proxying needs. #191
Conversation
|
Actually, I shouldn't have taken this one back, it still needs an r? from @jrgm and it doesn't need to make the train cut deadline tomorrow... |
| sudo: true | ||
| template: src=nginx.conf.j2 dest=/etc/nginx/conf.d/location/http_fxa_basket_proxy.conf | ||
| notify: reload nginx config | ||
|
|
jrgm
Oct 20, 2015
Contributor
I'm not clear on why this nginx proxy config is here since this basket proxy should be bound to localhost and is inaccessible via the ELB.
I'm not clear on why this nginx proxy config is here since this basket proxy should be bound to localhost and is inaccessible via the ELB.
jrgm
Oct 20, 2015
Contributor
Sorry. Nevermind what I said.
Sorry. Nevermind what I said.
|
lgtm. |
jrgm
added a commit
that referenced
this pull request
Oct 20, 2015
feat(basket): Use fxa-basket-proxy for all our basket-proxying needs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This updates fxa-dev to use the fxa-basket-proxy for everything basket-related - the fake basket server, the basket proxy, and the basket account-event processing logic. Depends on mozilla/fxa-basket-proxy#7.
/cc @jrgm , since we'll have to do something similar in production to switch over to the newly refactored codebase.