Skip to content
This repository has been archived by the owner. It is now read-only.

Handle URN redirect_uris for Loop #110

Closed
ckarlof opened this issue Jul 21, 2014 · 7 comments
Closed

Handle URN redirect_uris for Loop #110

ckarlof opened this issue Jul 21, 2014 · 7 comments

Comments

@ckarlof
Copy link
Contributor

@ckarlof ckarlof commented Jul 21, 2014

To support this: https://bugzilla.mozilla.org/show_bug.cgi?id=1041814

@seanmonstar
Copy link
Member

@seanmonstar seanmonstar commented Jul 22, 2014

Absolutely, as soon as I get name and redirectUri. Don't need dangling useless clients in the config.

@ckarlof
Copy link
Contributor Author

@ckarlof ckarlof commented Jul 23, 2014

@vladikoff
Copy link
Contributor

@vladikoff vladikoff commented Aug 8, 2014

@ckarlof we might need this for testing on latest, etc.

name : Hello,
redirectUri : {LOOP_SERVER}/fxa-oauth/redirect

where {LOOP_SERVER} is the loop api server, not the standalone client for now?
?

@vladikoff vladikoff changed the title Provision Oauth client credentials for Loop Provision Oauth client credentials for Hello Aug 8, 2014
@ckarlof
Copy link
Contributor Author

@ckarlof ckarlof commented Aug 8, 2014

@ckarlof
Copy link
Contributor Author

@ckarlof ckarlof commented Aug 20, 2014

My understanding is that the product name is "Firefox Hello", but let @rfeeley and @johngruen confirm. I don't know if the name should be "Firefox Hello" or just "Hello".

As far as a redirect_uri, Hello doesn't have a "Web flow" that supports FxA. FxA integration is entirely in the browser at the moment. Perhaps we should have it be fxa://oauth/?

The situation we don't want to show the link back to the relier is after the user clicks on her verification email after creating her account:

foo

@ckarlof
Copy link
Contributor Author

@ckarlof ckarlof commented Aug 21, 2014

New idea, for Loop we'll make the redirect_uri:

urn:ietf:wg:oauth:2.0:fx:webchannel

From what I can tell, this convention was first used by Google and others to signal the application uses application-specific "out of band" ways to get the code to the relier (with urn:ietf:wg:oauth:2.0:oob). We know how we'll deliver it to the relier, so let's make it explicit.

mozilla/fxa-content-server#1585 (comment)

@seanmonstar seanmonstar changed the title Provision Oauth client credentials for Hello Handle URN redirect_uris for Loop Sep 4, 2014
@seanmonstar
Copy link
Member

@seanmonstar seanmonstar commented Sep 4, 2014

Since Loop has credentials, but oauth-server goofs on URNs, i've commandeered this issue to fix URNs.

@seanmonstar seanmonstar modified the milestone: 0.21.0 Sep 4, 2014
@rfk rfk closed this in #134 Sep 4, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants