Skip to content
This repository has been archived by the owner. It is now read-only.

Passing in unknown scopes causes the login to hang just prior to redirect #264

Closed
crankycoder opened this issue Jun 2, 2015 · 2 comments
Closed

Comments

@crankycoder
Copy link

@crankycoder crankycoder commented Jun 2, 2015

During testing with MozStumbler, I noticed that if I pass in an unknown scope - in this case 'mozstumbler', the login screen hangs after login. The button remains disabled and I have to cancel. It's not apparent that an error occured as no error message is shown.

I get the same behaviour if I include 'profile:avatar' instead of mozstumbler in the list of scopes.

The login URL I used was :

https://stable.dev.lcip.org/oauth/signin?client_id=d0f6d2ed3c5fcc3b&state=99&scope=profile:email%20profile:display_name%20mozstumbler&redirect_uri=http://mycallback_url_here

sign_in_continue_to_insecure_mozilla_stumbler_leader_board

@jrgm
Copy link
Contributor

@jrgm jrgm commented Jun 2, 2015

So, the POST to 'https://oauth-stable.dev.lcip.org/v1/authorization' with that list of scopes correctly returns HTTP/1.1 400 Bad Request with {"code":400,"errno":114,"error":"Invalid scopes","message":"Invalid scopes","info":"https://github.com/mozilla/fxa-oauth-server/blob/master/docs/api.md#errors","invalidScopes":["mozstumbler"]}.

This is really a bug for fxa-content-server to handle presentation of the 400 error.

@crankycoder
Copy link
Author

@crankycoder crankycoder commented Jun 2, 2015

I've moved this bug over to fxa-content-server

@crankycoder crankycoder closed this Jun 2, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants