Remove ill-advised "00000000000000000000000000000000" hashedSecret values from config files #339

rfk · 2015-10-01T05:13:54Z

Per https://github.com/mozilla/fxa-oauth-server/pull/336/files#r40879520 using this magic value to denote a client with no secret was a bad idea; we should remove them from the dev config files in ./config so that nobody tries to resurrect it.

Closes #339

shane-tomlinson added the waffle:next label Oct 5, 2015

seanmonstar added waffle:now and removed waffle:next labels Oct 5, 2015

seanmonstar self-assigned this Oct 5, 2015

rfk added this to the FxA-0: quality milestone Oct 5, 2015

seanmonstar added waffle:progress and removed waffle:now labels Oct 12, 2015

seanmonstar added a commit that referenced this issue Oct 12, 2015

fix(config): remove 00000... from hashedSecrets

Loading status checks…

8dcfd56

Closes #339

seanmonstar mentioned this issue Oct 12, 2015

fix(config): remove 00000... from hashedSecrets #341

Merged

seanmonstar added waffle:review and removed waffle:progress labels Oct 12, 2015

vladikoff closed this in #341 Oct 13, 2015

vladikoff removed the waffle:review label Oct 13, 2015

mozilla / fxa-oauth-server Archived

Remove ill-advised "00000000000000000000000000000000" hashedSecret values from config files #339

Remove ill-advised "00000000000000000000000000000000" hashedSecret values from config files #339

rfk commented Oct 1, 2015

mozilla / fxa-oauth-server Archived

Remove ill-advised "00000000000000000000000000000000" hashedSecret values from config files #339

Remove ill-advised "00000000000000000000000000000000" hashedSecret values from config files #339

Comments

rfk commented Oct 1, 2015