This repository has been archived by the owner. It is now read-only.
for prod/stage get a git sha from config/version.json which the rpm build will provide #92
Conversation
…uild will provide
seanmonstar
added a commit
that referenced
this pull request
Jun 23, 2014
for prod/stage get a git sha from config/version.json which the rpm build will provide
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
So, I was looking at the stage builds and the value in the config file was '0.14.0-1' which was effectively the same as what we already know from package.json. It's really the git sha of the rpm that is wanted. To make things more like other services, I'll change the rpm build script to have a config/version.json and this PR will pull in that value at load time.
Also bumps the version to 0.14.1 (but maybe we should just go to 0.15.0).