set nodejs/request maxSockets to Infinity (or something more that default 5)

[jrgm]

nodejs-0.10.x by default limits outgoing connections to a pool of 5, which is generally not a good default. (In nodejs 0.12 and io.js, this limit goes away, IIRC). Anyways, there are a couple of places where we should remove this bottleneck in the image handling; I believe the option that does this in current request/nodejs-0.10.36 is pool: { maxSockets: Infinity } but check that.

https://github.com/mozilla/fxa-profile-server/blob/master/lib/routes/avatar/upload.js#L33-L35
https://github.com/mozilla/fxa-profile-server/blob/master/lib/server/web.js#L54-L59

/cc @ckolos fyi

[seanmonstar]

Yes.

[pdehaan]

Re: "In nodejs 0.12 and io.js, this limit goes away, IIRC",

HTTP

• maxSockets are no longer limited to 5. The default is now set to Infinity with the developer and the operating system given control over how many simultaneous connections an application can keep open to a given host.

— via http://blog.nodejs.org/2015/02/06/node-v0-12-0-stable/