Skip to content
This repository has been archived by the owner. It is now read-only.

feat(locales): add new supported locales #8

Merged
merged 1 commit into from Sep 30, 2016
Merged

feat(locales): add new supported locales #8

merged 1 commit into from Sep 30, 2016

Conversation

@vladikoff
Copy link
Contributor

@vladikoff vladikoff commented Sep 28, 2016

Fixes #7

@jrgm r?

@vladikoff
Copy link
Contributor Author

@vladikoff vladikoff commented Sep 28, 2016

Fixes #7

There are new locales with 100% translation at https://pontoon.mozilla.org/projects/firefox-accounts/

@vbudhram
Copy link
Contributor

@vbudhram vbudhram commented Sep 28, 2016

@vladikoff took a look at link and some of the locales are not listed at 100%. Do all translations have to be 100% before adding?

ast - 96%
bn-BD - 94%
ka - 89%
lv - 92%
nn-no - 94%
ro - 94%

@vladikoff
Copy link
Contributor Author

@vladikoff vladikoff commented Sep 28, 2016

@vladikoff took a look at link and some of the locales are not listed at 100%. Do all translations have to be 100% before adding?

I look at 'update date' and for 80%+ translation.

@jrgm
Copy link
Contributor

@jrgm jrgm commented Sep 29, 2016

Assuming we're all settled with es vs. es-ES, then r+

@vladikoff
Copy link
Contributor Author

@vladikoff vladikoff commented Sep 30, 2016

Assuming we're all settled with es vs. es-ES, then r+

What was the concern before? (currently seems like those locales are being updated at the same time)

@vladikoff vladikoff merged commit ea8d913 into master Sep 30, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@vladikoff vladikoff deleted the locales-71 branch Sep 30, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants