Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Implement password check on subscription cancellation #1088
The rough subscription management page merged in PR #961 did not include a password check when cancelling subscription. That will need to be implemented.
referenced this issue
May 14, 2019
Something to think about here: How to implement the actual password check as an API. Would it be secure enough to have an API that checks a password if the API is restricted to the same scope as other subscription management APIs? (i.e. it couldn't be used as a public password scan)
It just dawned upon me that asking for the user's password on a subscription service page negates the entire reason we put the subscriptions service on it's own domain - isolating the payment provider from finding out the user's password, sessionToken or Sync key material. A payment provider that goes malicious could slurp up the user's password, which could in turn be used to impersonate the user.
Can we take an alternative approach to asking for the password, perhaps using the delete repository flow from Github as an example. Instead of asking for the user's password, Github asks for the name of the repository being deleted.