Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[payments] Close button for "Plan Not Found" cannot repair error #1730

Open
ianb opened this issue Jul 10, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@ianb
Copy link
Member

commented Jul 10, 2019

In this code for the case when you link to a plan that doesn't exist, the close button on the error message simply reloads the page:

<DialogMessage className="dialog-error" onDismiss={locationReload}>
<h4>Plan not found</h4>
<p>No such plan for this product.</p>
</DialogMessage>
);
}

A not found is very likely a permanent error, and so reloading the page will only result in the same issue.

I'm not sure what it should do, though maybe the close button should simply be removed.

Other error messages in that file may be intermittent, and so reloading isn't unreasonable.

@lmorchard

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

Yeah, I think I threw this message in there as a guard against intermittently bad API data. There isn't really a reasonable place for the close button to go, since this is basically a 404 Not Found.

A better thing to do here is probably not present this error as a pop-up dialog and just stick the text in the page overall.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.