Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove signin-from-signup when email first is fully rolled out #201

Closed
rfk opened this issue Oct 19, 2016 · 7 comments
Closed

Remove signin-from-signup when email first is fully rolled out #201

rfk opened this issue Oct 19, 2016 · 7 comments

Comments

@rfk
Copy link
Member

@rfk rfk commented Oct 19, 2016

So it's not the first time I've seen a sentiment like this in review comments:

However, even that won't be correct because of the hateful,
hateful sign-in-from-the-sign-up-view feature.

Although perhaps never expressed quite so elegantly before ;-)

This "signin-from-signup" business is an expensive feature - it adds a lot of complexity and it complicates a lot of metrics analysis. We should take a look at the metrics and re-assure ourselves whether we're justified in keeping it and continuing to pay these costs.

@shane-tomlinson
Copy link
Member

@shane-tomlinson shane-tomlinson commented Oct 20, 2016

I have a proposal that I pitched to @ryanfeeley the other day. My feelings are not quite as strong as @philbooth's, but I think we can do a lot better. I am going to experiment tomorrow with doing like Persona (and now Google) does.

  1. If a user lands at /, show just an email address
  2. User types in an email, we check whether the email is registered:
    1. If email is registered, go through the signin flow.
    2. If the email is not registered, go through the signup flow.
@shane-tomlinson
Copy link
Member

@shane-tomlinson shane-tomlinson commented Sep 14, 2017

Maybe with email-first, we can kill this.

philbooth pushed a commit that referenced this issue Oct 17, 2017
chore(stable): update to stable train-49 and related
@vladikoff
Copy link
Contributor

@vladikoff vladikoff commented Mar 12, 2018

from mtg: the number of signins for signup should now go down...

@vladikoff vladikoff added the 2018 label Mar 12, 2018
@vladikoff vladikoff changed the title Validate whether signin-from-signup is delivering sufficient value Remove signin-from-signup when email first is fully rolled out Mar 12, 2018
@rfk
Copy link
Member Author

@rfk rfk commented Jun 27, 2018

Feels like we may be almost ready for this one... :-)

@rfk rfk added this to the FxA-155: signin papercuts milestone Jun 27, 2018
@shane-tomlinson
Copy link
Member

@shane-tomlinson shane-tomlinson commented Jun 29, 2018

This is largely a dup of https://github.com/mozilla/fxa-content-server/issues/6125, where the original signin and signup pages will be entirely removed w/ email-first. There are still some blockers, such as this bug that prevents IAM from using email-first.

@rfk
Copy link
Member Author

@rfk rfk commented Jul 2, 2018

Should we just close this out then?

@shane-tomlinson
Copy link
Member

@shane-tomlinson shane-tomlinson commented Jul 2, 2018

Should we just close this out then?

Closing as dup of https://github.com/mozilla/fxa-content-server/issues/6125

@ghost ghost removed the waffle:backlog label Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants