Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

payments server not starting on circle #2162

Closed
shane-tomlinson opened this issue Aug 12, 2019 · 4 comments

Comments

@shane-tomlinson

This comment has been minimized.

Copy link
Member Author

commented Aug 12, 2019

From https://60907-36831081-gh.circle-artifacts.com/0/logs/payments-server-PORT-3031-out.log:

> fxa-payments-server@1.143.1 build-start-dev /home/circleci/project/packages/fxa-payments-server
> npm run build && npm run start-dev


> fxa-payments-server@1.143.1 build /home/circleci/project/packages/fxa-payments-server
> react-scripts build

Creating an optimized production build...

Treating warnings as errors because process.env.CI = true.
Most CI servers set it automatically.

Failed to compile.

./src/store/utils.tsx
  Line 2:  'State' is defined but never used  @typescript-eslint/no-unused-vars


@shane-tomlinson

This comment has been minimized.

Copy link
Member Author

commented Aug 12, 2019

From https://60907-36831081-gh.circle-artifacts.com/0/logs/payments-server-PORT-3031-error.log:

The following changes are being made to your tsconfig.json file:
  - compilerOptions.jsx must be preserve (JSX is compiled by Babel)

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! fxa-payments-server@1.143.1 build: `react-scripts build`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the fxa-payments-server@1.143.1 build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/circleci/.npm/_logs/2019-08-12T16_54_31_467Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! fxa-payments-server@1.143.1 build-start-dev: `npm run build && npm run start-dev`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the fxa-payments-server@1.143.1 build-start-dev script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/circleci/.npm/_logs/2019-08-12T16_54_31_477Z-debug.log

@shane-tomlinson

This comment has been minimized.

Copy link
Member Author

commented Aug 12, 2019

Also saw while running locally:

The following changes are being made to your tsconfig.json file:
  - compilerOptions.jsx must be preserve (JSX is compiled by Babel)

@shane-tomlinson shane-tomlinson self-assigned this Aug 12, 2019

shane-tomlinson added a commit that referenced this issue Aug 12, 2019

fix(payments): Fix payments compilation
* Remove the unused `State`
* Accept the automatic tsconfig.json changes.

fixes #2162
@lmorchard

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

Huh, weird: This is probably fallout from my PR #2146 - but the tests passed there and didn't fail in this way. I wonder how that wasn't caught on Circle then?

shane-tomlinson added a commit that referenced this issue Aug 12, 2019

fix(payments): Fix payments compilation
* Remove the unused `State`

fixes #2162
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.