Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send subscription download email immediately rather than via queue #2797

Closed
lmorchard opened this issue Oct 8, 2019 · 0 comments · Fixed by #2800

Comments

@lmorchard
Copy link
Member

commented Oct 8, 2019

Per #2786 (comment):

we should file a follow up to move the email sending out of here.

Where the email being sent is the subscription download email and "here" is in the subhub message queue processing. We should move sending that email over into the subscription creation route on auth-server and so trigger it immediately on subscription.

@lmorchard lmorchard self-assigned this Oct 8, 2019
lmorchard added a commit to lmorchard/fxa that referenced this issue Oct 8, 2019
…tivation

- move sending of download email from async queue into API route
- clean up unused mailer references in subhub message processing.
- clean up unused oauthdb references in subscription API route

fixes mozilla#2797
lmorchard added a commit to lmorchard/fxa that referenced this issue Oct 8, 2019
…tivation

- move sending of download email from async queue into API route
- clean up unused mailer references in subhub message processing.
- clean up unused oauthdb references in subscription API route

fixes mozilla#2797
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.