Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why did we need xlarge on circleci again? #3515

Closed
dannycoates opened this issue Nov 27, 2019 · 3 comments · Fixed by #3602
Closed

Why did we need xlarge on circleci again? #3515

dannycoates opened this issue Nov 27, 2019 · 3 comments · Fixed by #3602
Assignees

Comments

@dannycoates
Copy link
Member

@dannycoates dannycoates commented Nov 27, 2019

follow-up to #3512

@lmorchard

This comment has been minimized.

Copy link
Member

@lmorchard lmorchard commented Nov 27, 2019

Yeah, to be clear: My switching us back to xlarge was very handwavy. I did it because it appeared to be the thing that worked and unblocked a bunch of PRs. I didn't manage to measure any resource usage or come up with a definitive reason why. Would be nice to do that, maybe trim some tests, and actually get us reliably running on a smaller resource class.

@lmorchard

This comment has been minimized.

Copy link
Member

@lmorchard lmorchard commented Nov 27, 2019

Things I did notice, though, included the content-server process getting killed and the Firefox instance running selenium tests dumping core. Those smell like out-of-memory issues to me, but it's just a hunch.

@chenba

This comment has been minimized.

Copy link
Contributor

@chenba chenba commented Dec 7, 2019

In one of the debug runs, I printed the value of os.freemem() when the process was terminated by the EPIPE error, and it was 16GB. That made no sense since it was using the default resource size, which should have had only 4GB.

@chenba chenba closed this in #3602 Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.