Notes cannot login in Firefox Nightly, halts at Profile Server request

[vladikoff]

The extension halts at the OPTIONS profile server /profile request

┆Issue is synchronized with this Jira Task
┆Issue Number: FXA-904

[vladikoff]

This works fine in Firefox Release, @rfk I think we had an issue tracking this that was fixed?

[vladikoff]

Related #2411

[rfk]

The Origin: null thing is from Bug 1405971. It looks like there's some related bustage in Bug 1607154 which sounds similar to what we're doing here (cross-origin request with Authorization header).

From the debug view, profile-server is correctly echoing back access-control-allow-origin: null in the response headers. But the webextension's origin is not actually "null", so the browser rejects its attempt to send credentials with the request.

We should be able to fix this by setting {cors: "ignore"} on the profile-server, but that requires us to update to the latest hapi.

[data-sync-user]

➤ Wil Clouser commented:

Is there a timeline when you need this?  Updating HAPI might be a can of worms

[chenba]

#2601 is the latest "update Hapi" issue.

[rfk]

IIUC the change in Nightly was backed out and Notes login should be working again. I've mentioned Notes as a good testcase for manual QA in the bug since it seems to exercise all the right bits of Firefox that come together to cause problems like this.

So, assuming things have indeed starting working again, I don't think there's a pressing time constraint here.

[vladikoff]

We should be able to fix this by setting {cors: "ignore"} on the profile-server, but that requires us to update to the latest hapi.

We upgraded hapi and can flip the switch if needed in the future. I checked latest Nightly and Notes login works for now 👍