Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement payment update on subscription management page #1091

Merged
merged 4 commits into from May 14, 2019

Conversation

Projects
None yet
2 participants
@lmorchard
Copy link
Member

commented May 13, 2019

Issue #1086

Broke this up into several commits, once I belatedly realized we didn't already have the API in place to fetch customer details from the subhub backend. So, three parts:

  1. the payment update form
  2. the auth server API to fetch the customer
  3. displaying current payment information for customer when available

No tests on the payment-server side yet, since I was waiting for UX in #718 to finalize things. But maybe that's a mistake?

@lmorchard lmorchard requested review from shane-tomlinson and ianb May 13, 2019

feat(payments): add payment update form to subscriptions management
- Also refactor Subscrptions route into smaller sub-components

fixes #1086

@lmorchard lmorchard force-pushed the lmorchard:1086-payment-update branch from 15fd91e to f0579f4 May 14, 2019

@ianb

ianb approved these changes May 14, 2019

Copy link
Member

left a comment

I don't understand the handleAuth() thing well enough to know what it does, though it does seem unclear to me how it handles authorization... should there be a test of the authorization to ensure the right access control?

Otherwise it seems fine? Obviously UI will get moved around. It feels like a general system around loading and error conditions would be useful (instead of handling it ad hoc inside individual components), but that can be a followup along with more final UX.

lmorchard added some commits May 13, 2019

feat(payments): add /oauth/subscriptions/customer auth server route
- tweaks to subhub client to better match [subhub][] API updates.
- disable one of the error cases in in-memory subhub stub

[subhub]: https://github.com/mozilla/subhub/blob/master/subhub/subhub_api.yaml#L183

issue #1086

@lmorchard lmorchard force-pushed the lmorchard:1086-payment-update branch from f0579f4 to 05e1a33 May 14, 2019

@lmorchard

This comment has been minimized.

Copy link
Member Author

commented May 14, 2019

Updated to add an alert bar at the top, fixed a linting issue, switched a <span /> to a null

@lmorchard lmorchard merged commit cbb4af4 into mozilla:master May 14, 2019

1 check passed

test Workflow: test
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.