Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts): use version sort to get last tag for train bump #1271

Merged
merged 1 commit into from May 28, 2019

Conversation

@philbooth
Copy link
Member

commented May 28, 2019

Fixes #1270.

Currently the release script fails when tagging 138.0 because the most recent tag chronologically is 136.6. This changes it so that path uses git's version-sort ordering instead.

@mozilla/fxa-devs r?

@philbooth philbooth added this to the Train 138 milestone May 28, 2019

@philbooth philbooth requested a review from mozilla/fxa-devs May 28, 2019

@philbooth philbooth self-assigned this May 28, 2019

@philbooth philbooth force-pushed the pb/1270-release-script-last-tag branch from 45b1ebf to 08d2c32 May 28, 2019

@@ -76,7 +76,11 @@ if [ "$STATUS" != "" ]; then
fi

# 3. Find the last tag.
LAST_TAG=`git describe --tags --abbrev=0`
if [ "$BUILD_TYPE" = "Train" ]; then
LAST_TAG=`git tag -l --sort=version:refname | tail -1`

This comment has been minimized.

Copy link
@vladikoff

vladikoff May 28, 2019

Member
git tag -l --sort=version:refname | tail -1
v1.137.4

👍

@philbooth philbooth merged commit cbf35ad into master May 28, 2019

1 check passed

test Workflow: test
Details

@philbooth philbooth deleted the pb/1270-release-script-last-tag branch May 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.