Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts): stop the release script getting hung up on colour codes #1311

Merged
merged 1 commit into from May 30, 2019

Conversation

@philbooth
Copy link
Member

commented May 30, 2019

@shane-tomlinson can you give this a try locally to see if it runs to completion for you? Works for me locally, so 馃.

@philbooth philbooth requested a review from shane-tomlinson May 30, 2019

@philbooth philbooth self-assigned this May 30, 2019

@shane-tomlinson
Copy link
Member

left a comment

r+! Works great @philbooth, sorry to drag you into this.

@philbooth

This comment has been minimized.

Copy link
Member Author

commented May 30, 2019

sorry to drag you into this

Don't be silly, I wrote the thing! More than happy to help debug/fix it!

@philbooth philbooth merged commit cdcf6ef into train-138 May 30, 2019

1 check passed

test Workflow: test
Details

@philbooth philbooth deleted the pb/decolourise-release-script branch May 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.