Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(payments): Add storybook deployment to _scripts/gh-pages.sh #1570

Merged
merged 1 commit into from Jun 12, 2019

Conversation

Projects
None yet
2 participants
@lmorchard
Copy link
Member

commented Jun 12, 2019

Reworked this PR to add storybook deployment to _scripts/gh-pages.sh.

Hard to exactly test, since it looks like this script only runs on merges to master. But, if it works, we should end up with Storybook deployments for fxa-payments-server here:

https://mozilla.github.io/fxa/fxa-payments-server/

@lmorchard lmorchard requested review from ianb and mozilla/fxa-devs Jun 12, 2019

@lmorchard

This comment has been minimized.

Copy link
Member Author

commented Jun 12, 2019

Oh, but unfortunately, it looks like we do have a task CI that clobbers the commit by removing it all: 01ebcc7

It worked on my repo, at least: https://lmorchard.github.io/fxa/fxa-payments-server/

@philbooth

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

See the existing script at:

https://github.com/mozilla/fxa/blob/master/_scripts/gh-pages.sh

You should be able to add your own step to that one and have it build/push when changes land in master. Don't forget to add a mv step too, as well as the actual build, so you get the path you want.

Side note, we also have an issue open for building tagged versions of docs for historical purposes, low priority of course:

#790

@lmorchard lmorchard force-pushed the lmorchard:storybook-deploy branch from 76321de to b6e1897 Jun 12, 2019

@lmorchard lmorchard changed the title feat(payments): Add deploy-storybook npm script to publish to gh-pages feat(payments): Add storybook deployment to _scripts/gh-pages.sh Jun 12, 2019

@lmorchard

This comment has been minimized.

Copy link
Member Author

commented Jun 12, 2019

Ah, cool. For some reason I'd missed that gh-pages.sh script. Revamped this PR to just add deployment there. I think it should work, but hard to test it without a merge to master it seems

@philbooth
Copy link
Member

left a comment

👍

@lmorchard

This comment has been minimized.

Copy link
Member Author

commented Jun 12, 2019

Crossing fingers that this doesn't break master... 🤞

@lmorchard lmorchard merged commit 4fac897 into mozilla:master Jun 12, 2019

1 check passed

test Workflow: test
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.