Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts): remove non-posix loop redirection from release script #1601

Merged
merged 2 commits into from Jun 25, 2019

Conversation

@philbooth
Copy link
Member

commented Jun 24, 2019

Maybe fixes #1590, but I don't have a failing machine to try it on.

There's also a seondary fix I noticed when trying to test this out on a clean machine, pulling from private/master failed because I hadn't done a git fetch private master.

@philbooth philbooth self-assigned this Jun 24, 2019

philbooth added some commits Jun 24, 2019

@philbooth philbooth force-pushed the pb/1590-bourne-release branch from 743a04d to f111e75 Jun 24, 2019

@shane-tomlinson

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

@philbooth - do you want someone on Windows to test this?

@rfk

This comment has been minimized.

Copy link
Member

commented Jun 25, 2019

FWIW this seems to allow ./release.sh to do the right thing for me under WSL, 👍 thanks @philbooth!

@philbooth

This comment has been minimized.

Copy link
Member Author

commented Jun 25, 2019

@philbooth philbooth requested a review from mozilla/fxa-devs Jun 25, 2019

@shane-tomlinson
Copy link
Member

left a comment

r+, thanks @philbooth

@philbooth philbooth merged commit 371f06b into master Jun 25, 2019

1 check passed

test Workflow: test
Details

@philbooth philbooth deleted the pb/1590-bourne-release branch Jun 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.