chore(payments): configure Renovate #1908

renovate · 2019-07-23T16:36:28Z

Welcome to Renovate! This is an onboarding PR to help you understand and configure settings before regular Pull Requests begin.

🚦 To activate Renovate, merge this Pull Request. To disable Renovate, simply close this Pull Request unmerged.

Detected Package Files

packages/fxa-payments-server/Dockerfile (dockerfile)
packages/fxa-payments-server/package.json (npm)

Configuration

🔡 Renovate has detected a custom config for this PR. Feel free to ask for help if you have any doubts and would like it reviewed.

Important: Now that this branch is edited, Renovate can't rebase it from the base branch any more. If you make changes to the base branch that could impact this onboarding PR, please merge them manually.

What to Expect

With your current configuration, Renovate will create 25 Pull Requests:

Pin dependencies

Schedule: ["every weekend"]
Branch name: renovate/pin-dependencies
Pin @babel/core to 7.4.5
Pin @babel/register to 7.4.4
Pin @sentry/browser to 5.5.0
Pin @sentry/node to 5.4.2
Pin @storybook/addon-actions to 5.1.9
Pin @storybook/addon-links to 5.1.9
Pin @storybook/addons to 5.1.9
Pin @storybook/react to 5.1.9
Pin @testing-library/react to 8.0.1
Pin @types/classnames to 2.2.8
Pin @types/jest to 24.0.15
Pin @types/jsdom to 12.2.3
Pin @types/nock to 10.0.3
Pin @types/node to 12.0.8
Pin @types/react to 16.8.21
Pin @types/react-dom to 16.8.4
Pin @types/react-redux to 7.1.0
Pin @types/react-router to 4.4.5
Pin @types/react-router-dom to 4.3.4
Pin @types/react-stripe-elements to 1.1.10
Pin @types/redux-actions to 2.6.1
Pin @types/sinon to 7.0.13
Pin @types/storybook__addon-actions to 3.4.3
Pin @types/storybook__addon-links to 3.3.5
Pin @types/storybook__react to 4.0.2
Pin @typescript-eslint/eslint-plugin to 1.10.2
Pin @typescript-eslint/parser to 1.10.2
Pin audit-filter to 0.4.3
Pin babel-eslint to 10.0.1
Pin babel-loader to 8.0.5
Pin classnames to 2.2.6
Pin concurrently to 4.1.0
Pin consolidate to 0.15.1
Pin convict to 4.4.1
Pin cors to 2.8.5
Pin cross-env to 5.2.0
Pin dayjs to 1.8.14
Pin eslint to 5.16.0
Pin eslint-plugin-fxa to 1.0.0
Pin eslint-plugin-react to 7.13.0
Pin eslint-plugin-sorting to 0.4.1
Pin express to 4.17.1
Pin express-http-proxy to 1.5.1
Pin helmet to 3.18.0
Pin jest-dom to 3.5.0
Pin joi to 14.3.1
Pin jsdom to 15.1.1
Pin jsdom-global to 3.0.2
Pin morgan to 1.9.1
Pin mozlog to 2.2.0
Pin nock to 10.0.6
Pin node-sass to 4.12.0
Pin npm-run-all to 4.1.5
Pin nyc to 14.1.1
Pin on-headers to 1.0.2
Pin onchange to 5.2.0
Pin react to 16.8.6
Pin react-dom to 16.8.6
Pin react-redux to 7.1.0
Pin react-router-dom to 5.0.1
Pin react-stripe-elements to 3.0.0
Pin react-test-renderer to 16.8.6
Pin redux to 4.0.1
Pin redux-actions to 2.6.5
Pin redux-promise-middleware to 6.1.1
Pin redux-thunk to 2.3.0
Pin sass-lint to 1.13.1
Pin serve-static to 1.14.1
Pin sinon to 7.3.2
Pin ts-jest to 24.0.2
Pin ts-node to 8.3.0
Pin type-to-reducer to 1.1.0
Pin typescript to 3.5.2

Update babel monorepo

Schedule: ["every weekend"]
Branch name: renovate/babel-monorepo
Upgrade @babel/core to 7.5.5
Upgrade @babel/register to 7.5.5
Upgrade babel-eslint to 10.0.2
Upgrade babel-loader to 8.0.6

Update dependency @sentry/node to v5.5.0

Schedule: ["every weekend"]
Branch name: renovate/sentry-monorepo
Upgrade @sentry/node to 5.5.0

Update dependency @testing-library/react to v8.0.6

Schedule: ["every weekend"]
Branch name: renovate/testing-library-react-8.x
Upgrade @testing-library/react to 8.0.6

Update dependency @types/classnames to v2.2.9

Schedule: ["every weekend"]
Branch name: renovate/classnames-2.x
Upgrade @types/classnames to 2.2.9

Update dependency @types/jsdom to v12.2.4

Schedule: ["every weekend"]
Branch name: renovate/jsdom-12.x
Upgrade @types/jsdom to 12.2.4

Update dependency @types/node to v12.6.8

Schedule: ["every weekend"]
Branch name: renovate/node-12.x
Upgrade @types/node to 12.6.8

Update dependency @types/react to v16.8.23

Schedule: ["every weekend"]
Branch name: renovate/react-16.x
Upgrade @types/react to 16.8.23

Update dependency @types/react-dom to v16.8.5

Schedule: ["every weekend"]
Branch name: renovate/react-dom-16.x
Upgrade @types/react-dom to 16.8.5

Update dependency @types/react-redux to v7.1.1

Schedule: ["every weekend"]
Branch name: renovate/react-redux-7.x
Upgrade @types/react-redux to 7.1.1

Update dependency @types/react-stripe-elements to v1.2.0

Schedule: ["every weekend"]
Branch name: renovate/react-stripe-elements-1.x
Upgrade @types/react-stripe-elements to 1.2.0

Update dependency concurrently to v4.1.1

Schedule: ["every weekend"]
Branch name: renovate/concurrently-4.x
Upgrade concurrently to 4.1.1

Update dependency dayjs to v1.8.15

Schedule: ["every weekend"]
Branch name: renovate/dayjs-1.x
Upgrade dayjs to 1.8.15

Update dependency eslint-plugin-react to v7.14.3

Schedule: ["every weekend"]
Branch name: renovate/eslint-plugin-react-7.x
Upgrade eslint-plugin-react to 7.14.3

Update dependency helmet to v3.20.0

Schedule: ["every weekend"]
Branch name: renovate/helmet-3.x
Upgrade helmet to 3.20.0

Update dependency react-scripts to v3.0.1

Schedule: ["every weekend"]
Branch name: renovate/react-scripts-3.x
Upgrade react-scripts to 3.0.1

Update dependency redux to v4.0.4

Schedule: ["every weekend"]
Branch name: renovate/redux-4.x
Upgrade redux to 4.0.4

Update dependency typescript to v3.5.3

Schedule: ["every weekend"]
Branch name: renovate/typescript-3.x
Upgrade typescript to 3.5.3

Update typescript-eslint monorepo to v1.13.0

Schedule: ["every weekend"]
Branch name: renovate/typescript-eslint-monorepo
Upgrade @typescript-eslint/eslint-plugin to 1.13.0
Upgrade @typescript-eslint/parser to 1.13.0

Update dependency @types/react-router to v5

Schedule: ["every weekend"]
Branch name: renovate/react-router-5.x
Upgrade @types/react-router to 5.0.3

Update dependency convict to v5

Schedule: ["every weekend"]
Branch name: renovate/convict-5.x
Upgrade convict to 5.0.0

Update dependency eslint to v6

Schedule: ["every weekend"]
Branch name: renovate/eslint-6.x
Upgrade eslint to 6.1.0

Update dependency jest-dom to v4

Schedule: ["every weekend"]
Branch name: renovate/jest-dom-4.x
Upgrade jest-dom to 4.0.0

Update dependency onchange to v6

Schedule: ["every weekend"]
Branch name: renovate/onchange-6.x
Upgrade onchange to 6.0.0

Update dependency react-stripe-elements to v4

Schedule: ["every weekend"]
Branch name: renovate/react-stripe-elements-4.x
Upgrade react-stripe-elements to 4.0.0

🚸 Branch creation will be limited to maximum 2 per hour, so it doesn't swamp any CI resources or spam the project. See docs for prhourlylimit for details.

❓ Got questions? Check out Renovate's Docs, particularly the Getting Started section.
If you need any further assistance then you can also request help here.

This PR has been generated by Renovate Bot. View repository job log here.

jaredhirsch · 2019-07-23T16:48:35Z

Hey all - Just getting renovate configured as part of #1128. I'll send an email to dev-fxacct to discuss (we can also discuss in this PR).

Some nice features of renovate, vs greenkeeper, are:

we can limit how often the dependency update PRs are opened, and how many PRs are opened at a given time
renovate is monorepo-aware and can update multiple FxA packages in a single PR

I'm going to see if renovate can be initially limited to the payments server, to reduce the initial number of PRs.

From top to bottom in the renovate.json file: * Limit renovate to 2 open PRs at a time * Do not allow renovate to auto-merge changes * Prefix renovate PRs with "renovate/" * Attempt to limit renovate to just the payments-server by ignoring other packages

Try a single includePath instead of many ignorePaths

Ignore the monorepo top-level config and package files

jaredhirsch · 2019-07-23T20:45:28Z

I think I've now contained the renovate PRs to just the payments server. 25 PRs is a lot, though mostly they are patch-level changes.

The full list of renovate options is here, if anyone has suggestions on other things to tweak: https://github.com/renovatebot/renovate/blob/master/lib/config/definitions.js

jaredhirsch · 2019-07-23T20:46:24Z

renovate.json

@@ -0,0 +1,16 @@
+{
+  "extends": [
+    "config:base"


The base config is here: https://renovatebot.com/docs/presets-config/#configbase

jaredhirsch · 2019-07-23T20:47:37Z

renovate.json

+  "extends": [
+    "config:base"
+  ],
+  "prConcurrentLimit": 2,


Each of these individual config options is detailed here: https://renovatebot.com/docs/configuration-options/

jaredhirsch · 2019-07-23T20:47:54Z

renovate.json

+  "branchPrefix": "renovate/",
+  "includePaths": [
+    "packages/fxa-payments-server/package.json",
+    "packages/fxa-payments-server/Dockerfile"


Currently only including the payments-server, as part of #1128

meandavejustice · 2019-07-24T16:02:44Z

renovate.json

+    "config:base"
+  ],
+  "prConcurrentLimit": 2,
+  "schedule": "every weekend",


Looks like this is the same schedule we were on for testpilot, I was taking care of those prs for a while each week and Monday was a good time for them 👍

lmorchard

LGTM - I had "upgrade deps" on my todo list for payments-server. There will most likely be some breakage with an upgrade of everything to latest, but it's worth grinding through as soon as the PR appears.

In particular: #1760

chore(deps): add renovate.json

3dc17a1

jaredhirsch changed the title ~~Configure Renovate~~ WIP - Configure Renovate Jul 23, 2019

jaredhirsch added 3 commits Jul 23, 2019

Update renovate config

753190b

From top to bottom in the renovate.json file: * Limit renovate to 2 open PRs at a time * Do not allow renovate to auto-merge changes * Prefix renovate PRs with "renovate/" * Attempt to limit renovate to just the payments-server by ignoring other packages

Update renovate config

151e25f

Try a single includePath instead of many ignorePaths

Update renovate.json

02280b1

Ignore the monorepo top-level config and package files

renovate bot changed the title ~~WIP - Configure Renovate~~ Configure Renovate Jul 23, 2019

jaredhirsch added 4 commits Jul 23, 2019

Fix syntax error

90398ab

See if package.json is getting skipped

69e8c43

Try to only ignore top-level package.json

3a72936

Update renovate.json

8ad0e23

jaredhirsch changed the title ~~Configure Renovate~~ chore(payments): configure Renovate Jul 23, 2019

jaredhirsch reviewed Jul 23, 2019

View changes

renovate.json

@@ -0,0 +1,16 @@

{

"extends": [

"config:base"

This comment has been minimized.

Sign in to view

jaredhirsch Jul 23, 2019
Member

The base config is here: https://renovatebot.com/docs/presets-config/#configbase

jaredhirsch reviewed Jul 23, 2019

View changes

renovate.json

"extends": [

"config:base"

],

"prConcurrentLimit": 2,

This comment has been minimized.

Sign in to view

jaredhirsch Jul 23, 2019
Member

Each of these individual config options is detailed here: https://renovatebot.com/docs/configuration-options/

jaredhirsch reviewed Jul 23, 2019

View changes

jaredhirsch added 2 commits Jul 23, 2019

Try removing the ignorePaths, see if the includePaths are enough

671c5cb

schedule renovate to just run on weekends

7b8ff9f

meandavejustice reviewed Jul 24, 2019

View changes

ianb mentioned this pull request Jul 24, 2019

Security checklist for payments server #1128

Closed

40 of 47 tasks complete

lmorchard approved these changes Jul 25, 2019

View changes

lmorchard merged commit 26259c6 into master Jul 25, 2019
1 check passed

1 check passed

test Workflow: test
Details

renovate bot deleted the renovate/configure branch Jul 25, 2019

jaredhirsch mentioned this pull request Aug 16, 2019

Add dependency management (Renovate) for all packages in monorepo #2228

Closed

2 of 16 tasks complete

mozilla / fxa

chore(payments): configure Renovate #1908

chore(payments): configure Renovate #1908

renovate bot commented Jul 23, 2019 •

edited

jaredhirsch commented Jul 23, 2019

jaredhirsch commented Jul 23, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

lmorchard left a comment •

edited

mozilla / fxa

chore(payments): configure Renovate #1908

chore(payments): configure Renovate #1908

Conversation

renovate bot commented Jul 23, 2019 • edited

Detected Package Files

Configuration

What to Expect

jaredhirsch commented Jul 23, 2019

jaredhirsch commented Jul 23, 2019

This comment has been minimized.

jaredhirsch Jul 23, 2019 Member

This comment has been minimized.

jaredhirsch Jul 23, 2019 Member

This comment has been minimized.

jaredhirsch Jul 23, 2019 Member

This comment has been minimized.

meandavejustice Jul 24, 2019 Member

lmorchard left a comment • edited

renovate bot commented Jul 23, 2019 •

edited

jaredhirsch Jul 23, 2019
Member

jaredhirsch Jul 23, 2019
Member

jaredhirsch Jul 23, 2019
Member

meandavejustice Jul 24, 2019
Member

lmorchard left a comment •

edited