Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(payments): Fix payments compilation #2163

Merged
merged 1 commit into from Aug 12, 2019

Conversation

@shane-tomlinson
Copy link
Member

commented Aug 12, 2019

  • Remove the unused State

fixes #2162

@mozilla/fxa-devs - r?

@shane-tomlinson shane-tomlinson requested a review from mozilla/fxa-devs Aug 12, 2019

@@ -13,7 +17,9 @@
"resolveJsonModule": true,
"isolatedModules": true,
"noEmit": true,
"jsx": "react"
"jsx": "preserve"

This comment has been minimized.

Copy link
@lmorchard

lmorchard Aug 12, 2019

Member

The new test setup that runs both frontend and server-side tests needs this "jsx": "react" setting, if I recall. Looks like that's what the CI failures for this PR are pointing at

This comment has been minimized.

Copy link
@lmorchard

lmorchard Aug 12, 2019

Member

Oh, I see, but other bits from create-react-app (i.e. react-scripts build) want to switch it back :/ Might need to do some more headscratching on this

This comment has been minimized.

Copy link
@shane-tomlinson

shane-tomlinson Aug 12, 2019

Author Member

I'll change it back.

fix(payments): Fix payments compilation
* Remove the unused `State`

fixes #2162

@shane-tomlinson shane-tomlinson force-pushed the i2162-fix-payments-startup branch from 0b340ea to 57d1b66 Aug 12, 2019

@lmorchard lmorchard merged commit d3b6f53 into master Aug 12, 2019

1 check passed

test Workflow: test
Details

@shane-tomlinson shane-tomlinson deleted the i2162-fix-payments-startup branch Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.