feat(payments): rework form validation to handle focus & blur independently #3027
Conversation
|
@johngruen Okay, I think this might address some of the issues we're been hitting on this form over time. Field contents get validated on change, but tooltips only get displayed on blur. That means the submit button should enable / disable as expected on form changes, but tooltips should be less noisy and not appear until the user moves away from the field. |
|
Also, this can probably most easily get tested via storybook:
|
| @@ -1,3 +1,5 @@ | |||
| { | |||
| "exceptions": [] | |||
| "exceptions": [ | |||
| "https://npmjs.com/advisories/1184" | |||
There was a problem hiding this comment.
Unrelated, but it came up today as a basically harmless advisory for our builds, so I figured I'd throw this in
| @@ -10,6 +10,17 @@ import { AppContext } from './lib/AppContext'; | |||
| // describe('App', () => {}); | |||
|
|
|||
| describe('App/AppErrorBoundary', () => { | |||
| beforeEach(() => { | |||
There was a problem hiding this comment.
Also unrelated to this PR, but quiets a useless error log during tests
…dently - rework onValidate handlers in form fields - they work on both focused and blurred states, can supply valid state and error message separately - remove most validation logic out of field components and into default validation handler functions - test updates to handle new arrangement - misc small bug and lint fixes - squelch expected exceptions during AppErrorBoundary test - add exception for NPM security advisory for https://npmjs.com/advisories/1184 fixes #2994
rework onValidate handlers in form fields - they work on both focused
and blurred states, can supply valid state and error message separately
remove most validation logic out of field components and into default
validation handler functions
test updates to handle new arrangement
misc small bug and lint fixes
squelch expected exceptions during AppErrorBoundary test
add exception for NPM security advisory for https://npmjs.com/advisories/1184
fixes #2994