Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fido2): add fido2 support - GSoC #5773

Merged
merged 1 commit into from Jul 22, 2020
Merged

Conversation

imskr
Copy link
Contributor

@imskr imskr commented Jun 26, 2020

Because

Add Fido2 webauthn support

This commit

Add fido2 libraries and helpers

Issue that this pull request solves

Closes: #5548 #5579 #5580 #5581 #5582

Added following attestations:

  • Fido-U2F
  • Fido-Packed

Checklist

  • My commit is GPG signed.
  • If applicable, I have modified or added tests that pass locally.
  • I have added necessary documentation (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of a change in the user interface.

Other information (Optional)

Any other information that is important to this pull request.

@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #5773 into main will decrease coverage by 1.65%.
The diff coverage is 73.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5773      +/-   ##
==========================================
- Coverage   93.84%   92.19%   -1.66%     
==========================================
  Files         299      189     -110     
  Lines       14417     8835    -5582     
  Branches      385      111     -274     
==========================================
- Hits        13530     8145    -5385     
+ Misses        884      654     -230     
- Partials        3       36      +33     
Impacted Files Coverage Δ
...rofile-server/lib/routes/ecosystem_anon_id/post.js 38.09% <31.57%> (-6.35%) ⬇️
packages/fxa-auth-server/bin/key_server.js 66.17% <50.00%> (-0.99%) ⬇️
packages/fxa-auth-server/lib/db.js 88.85% <50.00%> (-0.27%) ⬇️
packages/fxa-auth-server/lib/fido2/utils.js 72.97% <72.97%> (ø)
packages/fxa-auth-server/lib/fido2/challenge.js 76.92% <76.92%> (ø)
packages/fxa-auth-server/lib/payments/stripe.ts 82.92% <83.72%> (ø)
packages/fxa-auth-server/lib/oauth/jwt.js 100.00% <100.00%> (ø)
packages/fxa-auth-server/lib/routes/account.js 95.83% <100.00%> (-0.10%) ⬇️
...ges/fxa-auth-server/lib/routes/attached-clients.js 96.70% <100.00%> (+1.14%) ⬆️
packages/fxa-auth-server/lib/routes/oauth/index.js 98.73% <100.00%> (+0.03%) ⬆️
... and 97 more

@imskr
Copy link
Contributor Author

imskr commented Jun 29, 2020

@vbudhram A great article on:

  • packed-attestation on medium by FIDO member
  • U2F-attestation here

@imskr imskr force-pushed the sk-fido2 branch 3 times, most recently from 7ba21bd to c87eaf6 Compare Jul 1, 2020
@meandavejustice meandavejustice requested a review from vbudhram Jul 1, 2020
packages/fxa-auth-server/lib/fido2/challenge.js Outdated Show resolved Hide resolved
packages/fxa-auth-server/lib/fido2/keys/Packed.js Outdated Show resolved Hide resolved
packages/fxa-auth-server/lib/fido2/keys/Packed.js Outdated Show resolved Hide resolved
Copy link
Contributor

@vbudhram vbudhram left a comment

@imskr These utils LGTM. I'm in favor of landing this now since it is self contained and will help keep PR sizes manageable.

@vbudhram vbudhram merged commit e33aca8 into mozilla:main Jul 22, 2020
11 checks passed
dannycoates added a commit that referenced this pull request Jul 22, 2020
@imskr imskr changed the title feat(fido2): add fido2 support feat(fido2): add fido2 support - GSoC Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a util.js for fido2 server (server side)
2 participants