Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scripts): add monorepo-friendly release script #680

Merged
merged 2 commits into from Apr 4, 2019

Conversation

@philbooth
Copy link
Member

commented Apr 3, 2019

Adds a shell script that we can use to cut tags in the main service subdirectories. It doesn't attempt to tag stuff like fxa-shared or fxa-geodb. Eventually I hope we can just depend on those directly with ../ paths instead of like they're external dependencies.

It also doesn't push anything to any remotes. I think we should retain the human eyeball factor before pushing tags, building docker images and so on.

I realise that shell scripts aren't everyone's cup of tea so I've commented it liberally, more so than I would normally. If you think I've taken that too far let me know, happy to change it.

There's also a lengthy completion message for users telling them what they need to do next, i.e. check stuff then push.

Note that this script will not work for the first release we want to tag in this repo. The first release requires some extra logic to pull out the old tag for each subdirectory. I have written a separate script for that, first-release.sh. I didn't think it was worth including that script in the tree, since we'll only run it once. But I encourage people to play around with that one too, since we're going to use it (it's mostly the same as what you see here).

@mozilla/fxa-devs r?

@philbooth philbooth self-assigned this Apr 3, 2019

@philbooth philbooth requested a review from mozilla/fxa-devs Apr 3, 2019

@philbooth philbooth force-pushed the pb/release-script branch 2 times, most recently from 2f46801 to 8d3db8e Apr 3, 2019

@philbooth philbooth force-pushed the pb/release-script branch from 8d3db8e to 0e486d4 Apr 3, 2019

@vbudhram
Copy link
Contributor

left a comment

@philbooth This LGTM, thanks for the detailed breakdown of the steps. I just have a couple questions/comments but otherwise r+!

release.sh Outdated Show resolved Hide resolved
release.sh Show resolved Hide resolved
release.sh Outdated Show resolved Hide resolved

@clouserw clouserw added this to the Train 135 milestone Apr 3, 2019

@philbooth philbooth force-pushed the pb/release-script branch from 0e486d4 to fc81567 Apr 4, 2019

philbooth added some commits Apr 3, 2019

@philbooth philbooth force-pushed the pb/release-script branch from fc81567 to 2591db5 Apr 4, 2019

@philbooth philbooth merged commit 25d81ab into master Apr 4, 2019

1 check passed

test Workflow: test
Details

@ghost ghost removed train-135 labels Apr 4, 2019

@philbooth philbooth deleted the pb/release-script branch Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.