Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo):remove husky and associated git hooks #758

Merged
merged 1 commit into from Apr 5, 2019

Conversation

Projects
None yet
3 participants
@philbooth
Copy link
Member

commented Apr 5, 2019

Related to #689.

The git hooks aren't working in the monorepo context. Specifically:

  • The content server prepush linter hook runs on all changes, slowing down local development. Ideally it should check $PWD and only run if it's in the content server directory.

  • The auth server precommit hook never runs at all.

It doesn't appear that anyone has time to fix them at the moment, so let's remove them for now and we can bring them back when someone has time to figure it out. Keeping them in the tree broken is annoying.

@mozilla/fxa-devs r?

@philbooth philbooth added this to the Train 135 milestone Apr 5, 2019

@philbooth philbooth self-assigned this Apr 5, 2019

@philbooth philbooth requested a review from mozilla/fxa-devs Apr 5, 2019

@ghost ghost added the waffle:active label Apr 5, 2019

@philbooth philbooth removed the waffle:active label Apr 5, 2019

@philbooth

This comment has been minimized.

Copy link
Member Author

commented Apr 5, 2019

[if this lands, I'll change the title of the linked bug to something like "bring back husky"]

@philbooth philbooth force-pushed the pb/exeat-husky branch from b3f649e to 00a5c99 Apr 5, 2019

@vbudhram
Copy link
Contributor

left a comment

@philbooth LGTM 👍

@philbooth philbooth merged commit 92ef686 into master Apr 5, 2019

1 check passed

test Workflow: test
Details

@philbooth philbooth deleted the pb/exeat-husky branch Apr 5, 2019

@dannycoates

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

what is template-version-bump for?

@philbooth

This comment has been minimized.

Copy link
Member Author

commented Apr 5, 2019

what is template-version-bump for?

If any of the email templates in lib/senders/templates change, it bumps the respective version number(s) in lib/senders/templates/_versions.json. See the script in scripts/template-version-bump.js.

@philbooth

This comment has been minimized.

Copy link
Member Author

commented Apr 5, 2019

(or if you meant higher level than that, it's so that the email metrics in Amplitude can differentiate between different versions of the template)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.