Small fixes #82

Merged
merged 11 commits into from Dec 6, 2012

Projects

None yet

2 participants

@rossbruniges
Member

This fixes a bunch of noticed things as pointed out in #80

@andrewhayward andrewhayward and 1 other commented on an outdated diff Dec 5, 2012
gameon/base/static/base/css/home.css
border-radius: 0 0 16px 16px;
- background: #00283a;
+ background: #000a14 url('/static/base/img/css//homepage-footer_bg.gif') repeat-x top left;
@andrewhayward
andrewhayward Dec 5, 2012 Member

Double slash.

@andrewhayward
andrewhayward Dec 5, 2012 Member

Also, I did this already, but then you adjusted the opacity of the main section of the box, so I didn't bother committing the fix.

Are we now going back to solid colours? 'Cause I rather liked the effect of the background image showing through!

@rossbruniges
rossbruniges Dec 5, 2012 Member

You had done the checker-box effect? Did that ever make it into master or did I accidentally clobber it?

Yeah - back to solid colours as part of the design review notes - I likes the transparency too I must say

@andrewhayward
andrewhayward Dec 5, 2012 Member

Yes, I'd done the ridging dividers, but never committed them, because I pulled in the transparency change before pushing it out. So no, you didn't clobber it.

@rossbruniges
rossbruniges Dec 5, 2012 Member

That's something at least - was your work CSS or background image based? If it's CSS (without the background image) based then, if it's possible would rather use that...

@andrewhayward
andrewhayward Dec 5, 2012 Member

CSS based - no images necessary. I can throw it together again if you want.

@rossbruniges
rossbruniges Dec 5, 2012 Member

Yeah that would be cool - if you checkout this branch and send me a pull request we can bundle it all in together!

@rossbruniges rossbruniges Turns out that image uploads were not working at all. Now they do, an…
…d I've cleaned up the delete/edit flow a little bit
777649d
@andrewhayward andrewhayward and 1 other commented on an outdated diff Dec 5, 2012
gameon/submissions/views.py
form.save()
if entry.to_market == True:
return HttpResponseRedirect(settings.MARKETPLACE_URL)
else:
- return HttpResponseRedirect(reverse('submissions.entry_list',
- kwargs={'category': 'all'}))
+ messages.success(request, _('<strong>Game edited!</strong>'))
+ return HttpResponseRedirect(reverse('submissions.entry_single',
+ kwargs={'slug': new_slug}))
@andrewhayward
andrewhayward Dec 5, 2012 Member

You could just have used entry.slug here, as you did on (new) line 33.

@rossbruniges
rossbruniges Dec 5, 2012 Member

It might have been me being stupid but I thought that entry.slug was still returning the OLD value (before it changed) so in the case of an edit I assigned it to a value to use. I might have been wrong so will check again...

@rossbruniges
rossbruniges Dec 5, 2012 Member

You're right - I didn't need it!

@rossbruniges
Member

Have fixed the points you mentioned - also make a couple of additional changes (including one that turned out to be not that small) so a second glance and thumbs up (if applicable) would be awesome.

Thanks!

@rossbruniges rossbruniges merged commit 8041cc2 into mozilla:master Dec 6, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment