Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

Small screen #84

Merged
merged 4 commits into from Dec 6, 2012
Merged

Small screen #84

merged 4 commits into from Dec 6, 2012

Conversation

andrewhayward
Copy link
Contributor

A few bits and pieces, mostly to help submission form at smaller sizes

Having the character counter set at a fixed width seems completely ridiculous, and I can only imagine the plug-in author had some reason at some point. Anyway, removing the inline styling works fine for our needs, and the counter no longer breaks the form when it gets too small.
Gets to a point where the image gets behind the text, making it somewhat illegible.
The large padding in the 'market place' box means there's not a lot of room at smaller sizes. Equally, the submit button gets a bit weird so forcing onto new line.
@@ -111,7 +111,7 @@ <h2 class="whimper">What is Marketplace and why is it awesome?</h2>
</div>
{% endif %}
</div>
<div class="submit_row shout-box">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure that we need that extra submit class? submit_row.submit seems a bit weird...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, someone also used submit_row elsewhere, requiring a second hook for this field. If said person wanted to discuss something a little more meaningful than submit_row for rows not involving submission, I might be persuaded to entertain the idea of not having a seemingly redundant submit_row.submit class floating around.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That bastard! We should probably leave it up to him to fix it then.

rossbruniges added a commit that referenced this pull request Dec 6, 2012
@rossbruniges rossbruniges merged commit a037436 into mozilla:master Dec 6, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants