Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Some personal nits regarding some CSS, HTML and work for #86 and #87 #89

Merged
merged 1 commit into from Dec 6, 2012

Conversation

Projects
None yet
2 participants
Member

rossbruniges commented Dec 6, 2012

Personal nits being:

  • the user nav - made it thinner and look a bit better on small screens
  • h1 on the homepage for Game On
  • tried to make tabzilla get less in the way on small screens
  • reluctantly removed the fieldset from around the inital formset as firefox, fieldsets and file inputs do not mix
Member

andrewhayward commented Dec 6, 2012

Is this pull request really deleting all the images? That doesn't seem right, somehow.

Member

rossbruniges commented Dec 6, 2012

I think that's how github displays the images being updated. I ran them though imageOptim and have hopefully wiped around 100k+ off them all :)

Member

andrewhayward commented Dec 6, 2012

I figured that was probably the case, but seemed a bit weird. Otherwise, all looks fine.

@rossbruniges rossbruniges added a commit that referenced this pull request Dec 6, 2012

@rossbruniges rossbruniges Merge pull request #89 from rossbruniges/text-nits
Some personal nits regarding some CSS, HTML and work for #86 and #87
36ddabc

@rossbruniges rossbruniges merged commit 36ddabc into mozilla:master Dec 6, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment