Permalink
Browse files

ffsync-800346: sync completer.html

The firefox version of completer.html embedded in gcli.jsm is different
to the one in git. I suspect a mistake while creating a patch at some
point. The difference here is use of text nodes vs value attributes.
The difference is text wrapping [1] and the value attribute is possibly
slightly more correct although perhaps not enough to cause us to want to
fix the inconsistency in the markup member.

[1] https://developer.mozilla.org/en-US/docs/XUL/label

Signed-off-by: Joe Walker <jwalker@mozilla.com>
  • Loading branch information...
1 parent 672a2b7 commit 956e4b233a6d0856c105467fff0811a5c328e7e1 @joewalker joewalker committed Dec 18, 2012
Showing with 5 additions and 5 deletions.
  1. +5 −5 mozilla/gcli/ui/completer.html
@@ -2,10 +2,10 @@
<description
xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul">
<loop foreach="member in ${statusMarkup}">
- <label class="${member.className}">${member.string}</label>
+ <label class="${member.className}" value="${member.string}"></label>
</loop>
- <label class="gcli-in-ontab">${directTabText}</label>
- <label class="gcli-in-todo" foreach="param in ${emptyParameters}">${param}</label>
- <label class="gcli-in-ontab">${arrowTabText}</label>
- <label class="gcli-in-closebrace" if="${unclosedJs}">}</label>
+ <label class="gcli-in-ontab" value="${directTabText}"/>
+ <label class="gcli-in-todo" foreach="param in ${emptyParameters}" value="${param}"/>
+ <label class="gcli-in-ontab" value="${arrowTabText}"/>
+ <label class="gcli-in-closebrace" if="${unclosedJs}" value="}"/>
</description>

0 comments on commit 956e4b2

Please sign in to comment.