Permalink
Browse files

Bug 706983 (moretests): Object.defineProperty missing enumerable

- We should set it by default.
  • Loading branch information...
1 parent f3ccfec commit e76261efb4794b39b7d98680ff31dacb0526bb5f @joewalker joewalker committed Mar 28, 2012
Showing with 14 additions and 7 deletions.
  1. +8 −4 lib/gcli/ui/completer.js
  2. +2 −1 lib/gcli/ui/fields/basic.js
  3. +2 −1 lib/gcli/ui/fields/selection.js
  4. +2 −1 lib/gcli/ui/tooltip.js
View
@@ -180,7 +180,8 @@ Object.defineProperty(Completer.prototype, 'statusMarkup', {
member.className = 'gcli-in-' + member.status.toString().toLowerCase();
}, this);
return markup;
- }
+ },
+ enumerable: true
});
/**
@@ -193,7 +194,8 @@ Object.defineProperty(Completer.prototype, 'scratchLink', {
}
var command = this.requisition.commandAssignment.value;
return command && command.name === '{' ? this.scratchpad.linkText : null;
- }
+ },
+ enumerable: true
});
/**
@@ -207,7 +209,8 @@ Object.defineProperty(Completer.prototype, 'unclosedJs', {
var unclosedJs = jsCommand &&
this.requisition.getAssignment(0).arg.suffix.indexOf('}') === -1;
return unclosedJs;
- }
+ },
+ enumerable: true
});
/**
@@ -254,7 +257,8 @@ Object.defineProperty(Completer.prototype, 'emptyParameters', {
params.push(text);
}.bind(this));
return params;
- }
+ },
+ enumerable: true
});
exports.Completer = Completer;
@@ -254,7 +254,8 @@ DeferredField.prototype.getConversion = function() {
Object.defineProperty(DeferredField.prototype, 'isImportant', {
get: function() {
return this.field.isImportant;
- }
+ },
+ enumerable: true
});
@@ -182,7 +182,8 @@ SelectionTooltipField.prototype.setChoiceIndex = function(choice) {
Object.defineProperty(SelectionTooltipField.prototype, 'isImportant', {
get: function() {
return this.type.name !== 'command';
- }
+ },
+ enumerable: true
});
SelectionTooltipField.DEFAULT_VALUE = '__SelectionTooltipField.DEFAULT_VALUE';
View
@@ -249,7 +249,8 @@ Object.defineProperty(Tooltip.prototype, 'description', {
}
return this.assignment.param.description;
- }
+ },
+ enumerable: true
});
/**

0 comments on commit e76261e

Please sign in to comment.