Commits on Oct 13, 2012
  1. @joewalker
  2. @joewalker

    Merge branch 'noxhtml-768399'

    joewalker committed Oct 13, 2012
Commits on Oct 4, 2012
  1. @joewalker

    noxhtml-768399: Use innerHTML before XHTML alternatives

    This change is taken from a patch by Saran <ksk.3393@gmail.com> to
    gcli.jsm in mozilla-central. See this attachment for more details:
    https://bug768399.bugzilla.mozilla.org/attachment.cgi?id=667062
    
    Use of HTML (i.e. not XHTML) was failing when embedded in HTML documents
    where it would otherwise be valid. This reverses the logic to try
    innerHTML before createContextualFragment()
    joewalker committed Oct 4, 2012
Commits on Oct 2, 2012
  1. @joewalker

    Merge branch 'asyncout-773313'

    Conflicts:
    	lib/gclitest/helpers.js
    joewalker committed Oct 2, 2012
  2. @joewalker
  3. @joewalker

    docs-796881: Update readme.md

    Improve getting started and add links
    
    Signed-off-by: Joe Walker <jwalker@mozilla.com>
    joewalker committed Oct 2, 2012
Commits on Sep 17, 2012
  1. @joewalker

    menuclick-788215: Take spaces into account

    Add the 'matchPadding' option to setAssignment to copy the prefix and
    suffix from the original argument if the new argument doesn't contain
    any prefix/suffix.
    
    Signed-off-by: Joe Walker <jwalker@mozilla.com>
    joewalker committed Sep 17, 2012
  2. @joewalker

    menuclick-788215: Convert setAssignment to use options

    We had setAssignment and _setAssignment, but the distinction (internal
    vs. external) wasn't helpful, so we're merging them.
    We need to add another customization - to duplicate arg padding, and
    we don't want to do that as another parameter, so we are moving to an
    options syntax, and removing the negative on argUpdate while we are at
    it.
    
    Signed-off-by: Joe Walker <jwalker@mozilla.com>
    joewalker committed Sep 17, 2012
  3. @joewalker

    menuclick-788215: Pass arg to itemClicked not conversion

    Push the conversion down the stack closer to the requisition, which is
    where we want the conversion to be done.
    
    Signed-off-by: Joe Walker <jwalker@mozilla.com>
    joewalker committed Sep 17, 2012
  4. @joewalker

    menuclick-788215: Fix menu activation for <RETURN>

    The same 2 problems with menu click (i.e. using innerHTML and not adding
    a space prefix) need solving for keyboard activation too.
    
    Signed-off-by: Joe Walker <jwalker@mozilla.com>
    joewalker committed Sep 17, 2012
  5. @joewalker

    menuclick-788215: textContent strips HTML from name

    Using innerHTML worked fine on UAs without Proxy support because the
    name highlighting doesn't work on those platforms. The correct solution
    either way is to use textContent.
    
    Signed-off-by: Joe Walker <jwalker@mozilla.com>
    joewalker committed Sep 17, 2012
  6. @joewalker

    menuclick-788215: Correct case in gethighlightingProxy

    Capital 'H': s/gethighlightingProxy/getHighlightingProxy/g
    
    Signed-off-by: Joe Walker <jwalker@mozilla.com>
    joewalker committed Sep 17, 2012
  7. @joewalker

    menuclick-788215: Add ' ' prefix on menu click.

    There is a downside of this simple fix, that sometimes when there is a
    space as a suffix of the prior argument, that we end up with two spaces.
    While this is clearly a minor problem, it's nowhere near as serious as
    getting the menu click wrong.
    
    Signed-off-by: Joe Walker <jwalker@mozilla.com>
    joewalker committed Sep 17, 2012
  8. @joewalker

    Merge branch 'asyncout-773313' into landing

    Conflicts:
    	lib/gclitest/helpers.js
    
    Signed-off-by: Joe Walker <jwalker@mozilla.com>
    joewalker committed Sep 17, 2012
Commits on Sep 16, 2012
  1. @joewalker

    testconcat-707492: Update build for separate files

    Finally we update the Firefox build step to just copy over the GCLI
    test files, converting them into mochitest files as they go by:
    - Adding a test() function
    - Using helpers/assert/mockCommands from builtin
    
    This change also has the nice side-effect of getting rid of several
    mozilla build files from the GCLI tree.
    
    Signed-off-by: Joe Walker <jwalker@mozilla.com>
    joewalker committed Sep 16, 2012
  2. @joewalker

    testconcat-707492: remove options from exec

    For some reason the version of helpers in firefox was one step ahead
    of the version of helpers in GCLI in getting rid of the redundant
    'options' parameter. This brings GCLI up to date with the firefox way,
    needed now because the GCLI tests are now running against the firefox
    helpers implementation.
    
    Signed-off-by: Joe Walker <jwalker@mozilla.com>
    joewalker committed Sep 16, 2012
  3. @joewalker

    testconcat-707492: s/test/assert/g & fix testResource

    Moving test files into firefox JS land brings up a name clash over
    'test', where in mochitest 'test' is the name of the initial test
    function, and here is is what we call the assert module by default.
    
    It's normal with GCLI to call imported modules by their name, so we are
    renaming the import of the assert module to assert, which solves both
    problems.
    
    Also a previous changeset in this series removed all of the fakeDom and
    firefox guards from the tests. The resource test module still fails
    because we're not running the tests in the environment that it expects
    so the failing tests are re-skipped.
    
    Signed-off-by: Joe Walker <jwalker@mozilla.com>
    joewalker committed Sep 16, 2012
Commits on Sep 15, 2012
  1. @joewalker

    testconcat-707492: Remove test guards

    We were previously protecting all sort of failing tests against things
    like tiny fake DOM implementations. Since we're doing so much test
    hackery now is a good time to re-evaluate them all.
    
    Signed-off-by: Joe Walker <jwalker@mozilla.com>
    joewalker committed Sep 15, 2012
  2. @joewalker

    testconcat-707492: Remove defaultOptions

    defaultOptions were useful when we had environments (e.g. node) where
    we had no DOM, but since we've been using JS-DOM, we don't need to have
    a tiny fake DOM, because we've got a big fake DOM.
    
    Signed-off-by: Joe Walker <jwalker@mozilla.com>
    joewalker committed Sep 15, 2012
  3. @joewalker

    testconcat-707492: Create 'exports' alias

    In short: s/exports/mockCommands/g.
    In general we've been reducing the number of exports aliases, because
    although it's handy when moving code from one module to another to not
    have the functions change name from exports.foo to blah.foo, that's not
    a regular occurrence, and it creates complexity. However in this case
    where we're importing code into Firefox mochitests where everything is
    in the same global, it's much simpler.
    
    Signed-off-by: Joe Walker <jwalker@mozilla.com>
    joewalker committed Sep 15, 2012
Commits on Sep 10, 2012
  1. @joewalker

    asyncout-773313: Use test.checkCalled for async output

    We are now in a position to check delayed test output using our shiny
    new checkCalled test harness feature.
    
    Signed-off-by: Joe Walker <jwalker@mozilla.com>
    joewalker committed Sep 10, 2012
  2. @joewalker

    asyncout-773313: Note completed test run

    Signed-off-by: Joe Walker <jwalker@mozilla.com>
    joewalker committed Sep 10, 2012
  3. @joewalker

    asyncout-773313: Fix test runner

    The test runner was being somewhat overzealous with its calling of
    callbacks. Part of the fix is storing the callback so there are fewer
    of them. This also moves the asynchronaity to Test and removing it from
    the Suite. It needs to be in Test to satisfy assert.checkCalled, and so
    we don't really need it in Suite any more.
    
    Signed-off-by: Joe Walker <jwalker@mozilla.com>
    joewalker committed Sep 10, 2012
  4. @joewalker

    asyncout-773313: Test tweak - finally > variable

    It's better to put the test function call in a try {} finally {} block
    than store the return value, tidy-up and return because it's more
    resilient to failure, and clearer.
    
    Signed-off-by: Joe Walker <jwalker@mozilla.com>
    joewalker committed Sep 10, 2012
  5. @joewalker
  6. @joewalker

    buildupdate-755254: Remove tests

    The tests won't work in the built files without configuration, so this
    removes the tests until we have a chance to do the configuration.
    
    Signed-off-by: Joe Walker <jwalker@mozilla.com>
    joewalker committed Sep 10, 2012
  7. @joewalker

    buildupdate-755254: Update require filter

    We changed the config line with the earlier requirejs upgrade, but
    forgot to update the filter. This brings them in line.
    
    Signed-off-by: Joe Walker <jwalker@mozilla.com>
    joewalker committed Sep 10, 2012
  8. @joewalker

    buildupdate-755254: Use standard header for promise.js

    Updating dryice to recognise all that is an exercise in frustration.
    
    Signed-off-by: Joe Walker <jwalker@mozilla.com>
    joewalker committed Sep 10, 2012
  9. @joewalker

    buildupdate-755254: Require test command with tests

    Previously we required the test command with the other demo commands
    but it makes more sense to require it with the tests themselves so we
    don't have have a test command with no tests to run.
    
    Signed-off-by: Joe Walker <jwalker@mozilla.com>
    joewalker committed Sep 10, 2012
Commits on Sep 7, 2012
  1. @joewalker
  2. @joewalker
  3. @joewalker
  4. @joewalker
  5. @joewalker

    newpromise-708984: Correctly use central promise

    Previously we were ignoring that the functions were exported under the
    name 'Promise'.
    
    Signed-off-by: Joe Walker <jwalker@mozilla.com>
    joewalker committed Sep 7, 2012
Commits on Sep 5, 2012
  1. @joewalker

    fuzzy-764856: Update tests, remove hidden matches

    Several of the tests that checked for predictions were broken buy the
    original patch, this fixes them.
    Also hidden commands were considered for completion. They are now
    correctly hidden.
    Finally the spell module was tidied up to remove the need for a
    constructor, to fix some indents, etc.
    
    Signed-off-by: Joe Walker <jwalker@mozilla.com>
    joewalker committed Sep 5, 2012