From 02d309b930615695bfc59f08073715a2efae6ba3 Mon Sep 17 00:00:00 2001 From: Chris Nardi Date: Mon, 9 Apr 2018 22:34:28 +0000 Subject: [PATCH] Bug 1443103 [wpt PR 9800] - Correct serialization of box-shadow and text-shadow, a=testonly Automatic update from web-platform-testsCorrect serialization of box-shadow and text-shadow Following https://github.com/w3c/csswg-drafts/issues/2305, the canonical serialization for box-shadow was changed to the color then lengths. https://drafts.csswg.org/css-text-decor-3/#text-shadow-property also defines the canonical serialization for text-shadow as the color and then lengths. This caused the test to fail in Firefox, Chrome, and Safari. Update the test to match the spec in both instances. wpt-commits: a835486e59a94236a55107fe34925079b33ef247 wpt-pr: 9800 wpt-commits: a835486e59a94236a55107fe34925079b33ef247 wpt-pr: 9800 --- testing/web-platform/meta/MANIFEST.json | 2 +- .../variable-substitution-shadow-properties.html | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/testing/web-platform/meta/MANIFEST.json b/testing/web-platform/meta/MANIFEST.json index adc5805075316..924f9714de78d 100644 --- a/testing/web-platform/meta/MANIFEST.json +++ b/testing/web-platform/meta/MANIFEST.json @@ -528823,7 +528823,7 @@ "testharness" ], "css/css-variables/variable-substitution-shadow-properties.html": [ - "0febbaa27e8692583fa2cc29fc8a1523eea9be43", + "b02099a4131127140d023351faacec69527688dd", "testharness" ], "css/css-variables/variable-substitution-shorthands.html": [ diff --git a/testing/web-platform/tests/css/css-variables/variable-substitution-shadow-properties.html b/testing/web-platform/tests/css/css-variables/variable-substitution-shadow-properties.html index 58a858ecf5872..bd7b5ef334d6a 100644 --- a/testing/web-platform/tests/css/css-variables/variable-substitution-shadow-properties.html +++ b/testing/web-platform/tests/css/css-variables/variable-substitution-shadow-properties.html @@ -29,11 +29,11 @@ let templates = [ { testName:"box-shadow", - expectedValue:"1px 1px 1px 1px rgb(0,128,0)", + expectedValue:"rgb(0, 128, 0) 1px 1px 1px 1px", }, { testName:"text-shadow", - expectedValue:"1px 1px 1px rgb(0,128,0)", + expectedValue:"rgb(0, 128, 0) 1px 1px 1px", }, ];